Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: fix search parameters on load #468

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

jma
Copy link
Contributor

@jma jma commented Jan 11, 2022

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma force-pushed the maj-fix-search-params branch 2 times, most recently from 49e3f70 to e98ae11 Compare January 11, 2022 08:15
@jma jma added this to the v1.8.0 milestone Jan 11, 2022
@jma jma marked this pull request as ready for review January 11, 2022 08:16
@jma jma requested review from zannkukai and Garfield-fr January 11, 2022 08:40
@jma jma force-pushed the maj-fix-search-params branch from e98ae11 to d5e9b51 Compare January 31, 2022 10:37
@pronguen
Copy link
Contributor

pronguen commented Jan 31, 2022

* Does not add pre filters when they are present in the URL.
* Initializes filters with search filters during the loading application.
* Closes rero/rero-ils#2562.
* Closes rero/rero-ils#2527.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-fix-search-params branch from 165510a to 1dbe9f9 Compare February 3, 2022 13:31
@jma jma merged commit a825111 into rero:staging Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search gives no result after applying a sort Search parameter bestmatch should not be required
4 participants