Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

records: search refactoring #47

Merged
merged 1 commit into from
Nov 15, 2019
Merged

records: search refactoring #47

merged 1 commit into from
Nov 15, 2019

Conversation

sebdeleze
Copy link

  • Splits RecordSearchComponent in two components, one for integration in template and one for routing.
  • Moves check permissions to RecordUiService.
  • Fixes Pagination issues #45.

Co-Authored-by: Sébastion Délèze sebastien-deleze@rero.ch

@sebdeleze sebdeleze requested review from jma and Garfield-fr November 10, 2019 15:19
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in the other PRs.

* Splits RecordSearchComponent in two components, one for integration in template and one for routing.
* Moves check permissions to RecordUiService.
* Fixes #45.

Co-Authored-by: Sébastion Délèze sebastien-deleze@rero.ch
@sebdeleze sebdeleze merged commit 84d6af7 into rero:dev Nov 15, 2019
@sebdeleze sebdeleze deleted the sed-search-refactor branch November 15, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants