api: custom headers #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
approved these changes
Nov 11, 2019
jma
requested changes
Nov 11, 2019
| searchHeaders: { | ||
| 'Content-Type': 'application/rero+json' | ||
| }, | ||
| detailHeaders: { |
There was a problem hiding this comment.
Sounds like a bad name. You can use similar name than the invenio-records-rest API convention, i.e. list, item.
| return this.http.get<Record>(this.apiService.getEndpointByType(type, true) + '/', { params: httpParams }) | ||
| let httpHeaders: HttpHeaders; | ||
| if (headers) { | ||
| httpHeaders = new HttpHeaders(headers); |
There was a problem hiding this comment.
this can be done with an inline if statement.
There was a problem hiding this comment.
done, and I created a method to factorize this.
* Adds a config to specify custom headers to api calls. Co-Authored-by: Sébastion Délèze <sebastien-deleze@rero.ch>
jma
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Sébastion Délèze sebastien-deleze@rero.ch