Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: upgrade to angular 14 #525

Merged
merged 1 commit into from
Oct 13, 2022
Merged

dependencies: upgrade to angular 14 #525

merged 1 commit into from
Oct 13, 2022

Conversation

jma
Copy link
Contributor

@jma jma commented Oct 6, 2022

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma force-pushed the maj-angular14 branch 10 times, most recently from 6e399d3 to b9e704e Compare October 10, 2022 10:17
@jma jma changed the title maj angular14 dependencies: upgrade to angular 14 Oct 10, 2022
@jma jma marked this pull request as ready for review October 10, 2022 10:18
@jma jma requested review from Garfield-fr and zannkukai October 12, 2022 06:34
package.json Outdated
"@angular/forms": "^14.2.5",
"@angular/platform-browser": "^14.2.5",
"@angular/platform-browser-dynamic": "^14.2.5",
"@angular/router": "^14.2.5",
"@biesbjerg/ngx-translate-extract": "^7.0.3",
"@biesbjerg/ngx-translate-extract-marker": "^1.0.0",
"@ngx-formly/bootstrap": "^5.12.4",
"@ngx-formly/core": "^5.12.4",
"@ngx-translate/core": "^13.0.0",
"@ngx-translate/http-loader": "^6.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@ngx-translate/http-loader": "^7.0.0" ?

package.json Outdated
"npm-registry-fetch": "^9.0.0",
"path-parse": ">=1.0.7",
"postcss": ">=8.2.10",
"rxjs": "^6.6.7",
"serialize-javascript": "^5.0.1",
"simplemde": "^1.11.2",
"socket.io": "^3.1.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"socket.io": "^4.5" ?

package.json Outdated
"@angular-eslint/template-parser": "14.1.2",
"@angular/cli": "^14.2.5",
"@angular/compiler-cli": "^14.2.5",
"@angular/language-service": "^14.2.5",
"@ngx-formly/schematics": "^5.12.4",
"@types/jasmine": "^3.6.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@types/jasmine": "^4.3" ?

package.json Outdated
"@ngx-formly/schematics": "^5.12.4",
"@types/jasmine": "^3.6.9",
"@types/marked": "^2.0.3",
"@types/node": "^12.20.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@types/node": "^18.8" ?

package.json Outdated
"codelyzer": "^6.0.0",
"@typescript-eslint/eslint-plugin": "5.37.0",
"@typescript-eslint/parser": "5.37.0",
"eslint": "^8.23.1",
"husky": "^4.3.8",
"jasmine-core": "~3.6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"jasmine-core": "~4.3.0" ?

"codelyzer": "^6.0.0",
"@typescript-eslint/eslint-plugin": "5.37.0",
"@typescript-eslint/parser": "5.37.0",
"eslint": "^8.23.1",
"husky": "^4.3.8",
"jasmine-core": "~3.6.0",
"jasmine-spec-reporter": "~5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"jasmine-spec-reporter": "~7.0.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not we need to fix some deprecations in the test files first.

package.json Outdated
"codelyzer": "^6.0.0",
"@typescript-eslint/eslint-plugin": "5.37.0",
"@typescript-eslint/parser": "5.37.0",
"eslint": "^8.23.1",
"husky": "^4.3.8",
"jasmine-core": "~3.6.0",
"jasmine-spec-reporter": "~5.0.0",
"karma": "^6.3.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"karma": "^6.4" ?

"codelyzer": "^6.0.0",
"@typescript-eslint/eslint-plugin": "5.37.0",
"@typescript-eslint/parser": "5.37.0",
"eslint": "^8.23.1",
"husky": "^4.3.8",
"jasmine-core": "~3.6.0",
"jasmine-spec-reporter": "~5.0.0",
"karma": "^6.3.4",
"karma-chrome-launcher": "~3.1.0",
"karma-jasmine": "~4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"karma-jasmine": "~5.1.0" ?

package.json Outdated
"codelyzer": "^6.0.0",
"@typescript-eslint/eslint-plugin": "5.37.0",
"@typescript-eslint/parser": "5.37.0",
"eslint": "^8.23.1",
"husky": "^4.3.8",
"jasmine-core": "~3.6.0",
"jasmine-spec-reporter": "~5.0.0",
"karma": "^6.3.4",
"karma-chrome-launcher": "~3.1.0",
"karma-jasmine": "~4.0.0",
"karma-jasmine-html-reporter": "^1.5.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"karma-jasmine-html-reporter": "^2.0"

package.json Outdated
Comment on lines 89 to 90
"ts-node": "^9.1.1",
"tslint": "~6.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ?

@jma jma force-pushed the maj-angular14 branch 3 times, most recently from c94fa91 to 3e3db9a Compare October 12, 2022 13:59
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@jma jma merged commit 73cc1f1 into rero:staging Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants