search: fix number facets behavior #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behavior to know if a facet is selected or not are based on query string argument; the value of a query string argument is always a "string". But For an aggregation/facet with only numeric values, all checks failed because we compared "string" versus "number". To fix this, we add the ".toString()" (available for all native datatype) method into the required functions. Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Garfield-fr
approved these changes
May 15, 2023
jma
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior to know if a facet is selected or not are based on query string argument; the value of a query string argument is always a "string". But For an aggregation/facet with only numeric values, all checks failed because we compared "string" versus "number". To fix this, we add the ".toString()" (available for all native datatype) method into the
required functions.