Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: fix translate module import for lazy loading #60

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 20, 2019

  • Configures ngx-translate to be used in a lazy loading module.
  • Exports CoreModule in RecordModule.

Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch

Why are you opening this PR?

  • To fix the use of ng-core in a lazy loading module.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@jma jma requested a review from sebdeleze November 20, 2019 20:17
* Configures ngx-translate to be used in a lazy loading module.
* Exports CoreModule in RecordModule.
* Removes duplcate exports in RecordModule.

Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@jma jma force-pushed the maj-translate-module branch from 451e34f to b596fc4 Compare November 21, 2019 07:22
@jma jma requested a review from benerken November 21, 2019 07:28
@jma jma merged commit 1d0b938 into rero:dev Nov 21, 2019
@jma jma deleted the maj-translate-module branch November 21, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants