Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: add language translation service and pipe #68

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Nov 29, 2019

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Adds 4 languages: de, fr, en, it.
  • Adds translation service for language.
  • Adds pipe for language.
  • Removes dependency to cospired/i18n-iso-languages.

How to test?

  • Check language translation on interface (facet language)

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* Adds 4 languages: de, fr, en, it.
* Adds translation service for language.
* Adds pipe for language.
* Removes dependency to cospired/i18n-iso-languages.
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@sebdeleze sebdeleze merged commit a1b8816 into rero:dev Nov 29, 2019
@Garfield-fr Garfield-fr deleted the zub-language branch December 2, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants