Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregation: Fix more/less link #69

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Fixes display more/less link if the parameter aggregationBucketSize isn't defined on data routing.

How to test?

  • Disabled parameter aggregationBucketSize on routing and show if the link "more" is not present.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr requested a review from jma December 2, 2019 06:06
@Garfield-fr Garfield-fr force-pushed the zub-aggregation-fix-more-less branch from fbdd9e7 to 7646776 Compare December 2, 2019 06:06
* Fixes display more/less link if the parameter aggregationBucketSize
  isn't defined on data routing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-aggregation-fix-more-less branch from 7646776 to edc91ae Compare December 2, 2019 07:56
@jma jma merged commit 15b2b69 into rero:dev Dec 2, 2019
@Garfield-fr Garfield-fr deleted the zub-aggregation-fix-more-less branch December 6, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants