general: fix redirection after add, update, delete resource #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-fix-router-redirection
branch
from
1ec336e to
ef9c54b
Compare
Garfield-fr
requested review from
jma,
sebdeleze,
AoNoOokami,
lauren-d and
zannkukai
40 tasks
jma
approved these changes
Dec 8, 2019
| @@ -153,7 +154,7 @@ export class DetailComponent implements OnInit { | |||
| public deleteRecord(pid: string) { | |||
| this.recordUiService.deleteRecord(this.route.snapshot.paramMap.get('type'), pid).subscribe((result: any) => { | |||
| if (result === true) { | |||
| this.location.back(); | |||
| this.router.navigate(['../..'], {relativeTo: this.route}); | |||
There was a problem hiding this comment.
can you add a small comment as it is not easy to understand. For ex. back to the list or similar.
AoNoOokami
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
This PR doesn't solve point 29. of rero/rero-ils-ui#43:
New circulation policies > Cancel. Got a an error: rero_ils_admin_ui.4706512e.js:2 POST https://ilsdev.test.rero.ch/api/circ_policies/ 400 (BAD REQUEST) on console.log.
I unckecked it.
sebdeleze
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Why are you opening this PR?
How to test?
Code review check list