autocomplete: fix multiple search input in a page #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The input value is set only if the url q parameters is for the autocomplete for example: records/documents. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
40 tasks
sebdeleze
reviewed
Dec 9, 2019
Comment on lines
+109
to
+111
| index: undefined, | ||
| category: undefined, | ||
| href: undefined |
There was a problem hiding this comment.
I think it's better null than undefined as discussed during the formation.
sebdeleze
approved these changes
Dec 9, 2019
AoNoOokami
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autocomplete for example: records/documents.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
How to test?
Code review check list