Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patrons: rewrite the profile in Angular #528

Merged
merged 1 commit into from
Mar 9, 2021
Merged

patrons: rewrite the profile in Angular #528

merged 1 commit into from
Mar 9, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Feb 23, 2021 •
edited
Loading

  • Rewrites the user profile in Angular to optimize performance (when the
    patron has many loans, requests and/or loan history) and to improve
    the user experience.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Optimisation

Dependencies

My PR depends on PR(s):

How to test?

  • Check all tabs on profile and user actions

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr added this to the v1.1.0 milestone Feb 23, 2021
@Garfield-fr Garfield-fr force-pushed the zub-patron-profile branch 5 times, most recently from dbba787 to 0d2f706 Compare February 24, 2021 12:14
@Garfield-fr Garfield-fr added f: public ui Public interface, as opposed to the professional interface refactoring labels Feb 24, 2021
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Feb 24, 2021 •
edited by Garfield-fr
Loading

  • The 'scope' field is missing from the ILL requests detail.
  • If the tab is empty it should mention that there is no xxx. Ex: No requests, No history.

iGormilhit
iGormilhit suggested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

patrons: rewrite the profile in Angular

* Rewrites the user profile in Angular to optimize performance (when the
  patron has many loans, requests and/or loan history) and to improve
  the user experience.

@Garfield-fr Garfield-fr force-pushed the zub-patron-profile branch 2 times, most recently from 1e19bdb to 03fcbd6 Compare February 25, 2021 08:41
@Garfield-fr Garfield-fr changed the title patron: rewrite the profile in angular patrons: rewrite the profile in Angular Feb 25, 2021
@Garfield-fr Garfield-fr force-pushed the zub-patron-profile branch 5 times, most recently from a5e8b3d to 9c985a2 Compare February 26, 2021 10:56
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.0.2 Mar 1, 2021
@Garfield-fr Garfield-fr force-pushed the zub-patron-profile branch 3 times, most recently from 3857d16 to 33f3be6 Compare March 2, 2021 12:36
zannkukai
zannkukai reviewed Mar 2, 2021
View reviewed changes
@Garfield-fr Garfield-fr force-pushed the zub-patron-profile branch 9 times, most recently from 987a70e to 7e38c42 Compare March 9, 2021 06:09
@Garfield-fr Garfield-fr requested a review from zannkukai March 9, 2021 07:27
zannkukai
zannkukai reviewed Mar 9, 2021
View reviewed changes
...profile/patron-profile-requests/patron-profile-request/patron-profile-request.component.html Outdated
<span [translate]="'(position {{ rank }} in waiting list)'" [translateParams]="{ rank: record.metadata.rank }"></span>
</ng-container>
</div>
<div class="col-lg-2 col-sm-2 text-right">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

col-2

...search/src/app/patron-profile/patron-profile-requests/patron-profile-requests.component.html Outdated
<section id="requests-section" class="row px-3 mt-2 my-1">
<div class="col mr-1 d-none d-lg-block">
<div class="row p-2 bg-dark rounded text-light">
<div class="col-lg-4 col-sm-4 pl-0" translate>Title</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

col-4, col-4, col-6

projects/public-search/src/app/patron-profile/patron-profile.component.html
You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
-->
<ngx-loading-bar [includeSpinner]="false" height="3px"></ngx-loading-bar>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, Is this agree for everyone ? Should be, at least, mentioned at a daily

@Garfield-fr
patrons: rewrite the profile in Angular
0b69cf4 
* Rewrites the user profile in Angular to optimize performance (when the
  patron has many loans, requests and/or loan history) and to improve
  the user experience.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr requested a review from zannkukai March 9, 2021 08:59
@Garfield-fr Garfield-fr merged commit 142e9bf into rero:dev Mar 9, 2021
@Garfield-fr Garfield-fr deleted the zub-patron-profile branch May 6, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

@sebdeleze sebdeleze Awaiting requested review from sebdeleze

@benerken benerken Awaiting requested review from benerken

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees
No one assigned
Labels
f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Garfield-fr @ManaDeweerdt @iGormilhit @sebdeleze @zannkukai @benerken