Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add new fields to a duplicate bibliographic record #1601

Closed
JoelleDosimont opened this issue Jan 12, 2021 · 0 comments · Fixed by rero/ng-core#338 or #1647
Closed

Cannot add new fields to a duplicate bibliographic record #1601

JoelleDosimont opened this issue Jan 12, 2021 · 0 comments · Fixed by rero/ng-core#338 or #1647
Assignees
@jma
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months)

Comments

@JoelleDosimont
Copy link
Contributor

Describe the bug
When duplicating a bibliographic records, the editor opens a new record with the bibliographic information of the original record. In the editor, I'm unable to add new fields to it. I can chose a new field with the "Add fields" menu, but it doesn't show in the editor. The "Add fields" menu contains all fields, not taking into account it's presence in the record.

To Reproduce

  1. Choose a bibliographic record
  2. Click on 'Duplicate'
  3. In the new record editor, try to add a field that is not already in the record.
  4. See error

Expected behavior
The "Add field" menu should only contains the missing field of the bibliographic record.
When clicking on a field to add, it should be added to the editor in order to be able to complete it.

Context
Problem appears on ils.test.rero.ch
version: v0.15.0
@JoelleDosimont JoelleDosimont added triage bug Breaks something but is not blocking labels Jan 12, 2021
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Jan 14, 2021
@jma jma self-assigned this Jan 27, 2021
jma added a commit to jma/ng-core that referenced this issue Jan 27, 2021
@jma
editor: fix issues
ba2a45f 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Jan 27, 2021
@jma
editor: fix issues
0529063 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Jan 27, 2021
@jma
editor: fix issues
3c53cb3 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
This was referenced Jan 27, 2021
Merged
Merged
jma added a commit to jma/ng-core that referenced this issue Jan 27, 2021
@jma
editor: fix issues
f289992 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Jan 28, 2021
@jma
editor: fix issues
4198063 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes rero#328.
* Closes rero#327.
* Closes rero#325.
* Closes rero#248.
* Closes rero#242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@ManaDeweerdt ManaDeweerdt added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Feb 1, 2021
jma added a commit to rero/ng-core that referenced this issue Feb 10, 2021
@jma
editor: fix issues
ca9caf8 
* Fixes tester document search routing.
* Removes useless log messages.
* Fixes import paths.
* Replaces the css classes such as `editor-title` by a `card` wrapper.
* Moves some common code lines in the editor service.
* Moves the field label html code into a specific component.
* Adds new `containerCSSClass`, `itemCSSClass` and `cssClass` to allow
  field grid positions.
* Renders the hide/show/clone button in the children field instead of
  the parent (array, object) component.
* Adds external link support for remote typeahead editor component.
* Closes #328.
* Closes #327.
* Closes #325.
* Closes #248.
* Closes #242.
* Closes rero/rero-ils#1604.
* Closes rero/rero-ils#1601.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: fix issues jma/ng-core
editor: adapt JSON schema form options jma/rero-ils
4 participants
@jma @iGormilhit @ManaDeweerdt @JoelleDosimont