Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐍 Let serde be an optional dependency #13

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

tosti007
Copy link
Contributor

This PR marks serde as an option dependency and only derives the various Serialize and Deserialize traits when this feature is enabled.

Regardless of not forcing the user to have the serde dependency, having the serde feature of egui (optionally) enabled is a requirement for #12.

@tosti007
Copy link
Contributor Author

Turns out the CI compiles with --no-default-features. However the examples do some save and load the previous app state, which requires the serde feature. As I see it we have two options here:

  1. Add the serde dependency for the examples.
  2. Add some #[cfg(feature = "serde")] and #[allow(clippy::unused_mut)] statements.

I am not sure what the preferred route is here, if option 1 is the desired solution, I am not sure how to do such change.

@tosti007
Copy link
Contributor Author

Just rebased on latest main and I think no additional changes were needed.

tosti007 added a commit to Traverse-Research/egui_tiles that referenced this pull request Sep 28, 2023
@tosti007 tosti007 requested a review from emilk November 2, 2023 14:31
tosti007 added a commit to Traverse-Research/egui_tiles that referenced this pull request Nov 2, 2023
@emilk emilk merged commit 8aaa57b into rerun-io:main Nov 2, 2023
5 checks passed
@tosti007 tosti007 deleted the optional-serde branch November 3, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants