Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs when having multiple Trees visible at the same time #68

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix bugs when having multiple Trees visible at the same time #68

merged 2 commits into from
Jun 24, 2024

Conversation

GuillaumeSchmid
Copy link
Contributor

@GuillaumeSchmid GuillaumeSchmid commented May 30, 2024 •
edited by emilk
Loading

This verion seeds the id from parent ui.id()

@GuillaumeSchmid
Fix proposal for fixing ui generation using the same TilesIds from mu…
88387ad 
…ltiple trees.

This verion seeds the id from parent ui.id()
bug rerun-io#64
@GuillaumeSchmid GuillaumeSchmid changed the title Fix proposal for fixing ui generation using the same Tiles Ids from multiple trees Another fix proposal for fixing ui generation using the same Tiles Ids from multiple trees May 31, 2024
@emilk emilk added the include in changelog Include this in CHANGELOG.md label Jun 24, 2024
@emilk emilk changed the title Another fix proposal for fixing ui generation using the same Tiles Ids from multiple trees Support bugs when having multiple Trees with collide TileIds Jun 24, 2024
@emilk emilk changed the title Support bugs when having multiple Trees with collide TileIds Fix bugs when having multiple Trees visible at the same time Jun 24, 2024
@emilk emilk added the bug Something isn't working label Jun 24, 2024
@emilk emilk merged commit 7530ba6 into rerun-io:main Jun 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working include in changelog Include this in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate Id when creating 2 pane trees in the same app.
2 participants
@GuillaumeSchmid @emilk