Optimize mp4 parse times by not copying video data #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there's still a lot of optimization/refactor potential in this crate, which is why this doesn't close the above issue, but not copying all the video data is a great start.
Samples now have a helper which returns a range into the video data.
Breaking changes
Track::read_sample
, superseded bySample::range
which can be used to index the original bufferTrack::data
read_file
now returns a tuple of(Mp4, Vec<u8>)
so that the original byte buffer is not lost and can be used together withSample::range