-
Notifications
You must be signed in to change notification settings - Fork 372
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Moves `Caches` from `AppState` to the `StoreHub`, and make them per-recording instead of viewer-wide in the process. This is: * a pre-requisite to fix the repeated static logging issues (#7404) * a necessary step towards proper secondary caching * a fix for a very old issue: cache memory is not reclaimed when closing a recording I'm not a fan of the implementation: it's brittle, confusing, and I don't like it. Still, it's a net improvement over the status quo, and fixes a very annoying "leak" for end users. Before: https://github.com/user-attachments/assets/a54c1923-a939-4700-a485-eeb2a2dd4966 After: https://github.com/user-attachments/assets/dd5adb65-d328-474c-bc31-e65a59332f03 --- * Part of #7404
- Loading branch information
Showing
7 changed files
with
83 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters