Make ArrowString an opaque type (#8365)

* Par of #3741
rerun-io · Dec 9, 2024 · 04125bb · 04125bb
1 parent 83a7376
commit 04125bb
Show file tree

Hide file tree

Showing 20 changed files with 98 additions and 58 deletions.
diff --git a/crates/build/re_types_builder/src/codegen/rust/deserializer.rs b/crates/build/re_types_builder/src/codegen/rust/deserializer.rs
@@ -572,7 +572,7 @@ fn quote_arrow_field_deserializer(
                 objects,
                 datatype,
                 IteratorKind::ResultOptionValue,
-                quote!(::re_types_core::ArrowString).into(),
+                quote!(::re_types_core::ArrowString::from).into(),
             );
 
             let data_src_buf = format_ident!("{data_src}_buf");

diff --git a/crates/build/re_types_builder/src/codegen/rust/serializer.rs b/crates/build/re_types_builder/src/codegen/rust/serializer.rs
@@ -606,7 +606,7 @@ fn quote_arrow_field_serializer(
                     (
                         quote! {
                             .flat_map(|datum| {
-                                datum.#quoted_member_accessor.0
+                                datum.#quoted_member_accessor.into_arrow2_buffer()
                             })
                         },
                         quote! {
@@ -618,7 +618,7 @@ fn quote_arrow_field_serializer(
                 } else {
                     (
                         quote! {
-                            .flat_map(|s| s.0)
+                            .flat_map(|s| s.into_arrow2_buffer())
                         },
                         quote! {
                             .map(|datum| datum.len())

diff --git a/crates/store/re_chunk/src/iter.rs b/crates/store/re_chunk/src/iter.rs
@@ -456,7 +456,7 @@ impl Chunk {
                     let offsets = &offsets.as_slice()[idx..idx + len];
                     let lengths = &lengths.as_slice()[idx..idx + len];
                     izip!(offsets, lengths)
-                        .map(|(&idx, &len)| ArrowString(values.clone().sliced(idx as _, len)))
+                        .map(|(&idx, &len)| ArrowString::from(values.clone().sliced(idx as _, len)))
                         .collect_vec()
                 }),
         )

diff --git a/crates/store/re_types/src/blueprint/datatypes/component_column_selector.rs b/crates/store/re_types/src/blueprint/datatypes/component_column_selector.rs
diff --git a/crates/store/re_types/src/blueprint/datatypes/selected_columns.rs b/crates/store/re_types/src/blueprint/datatypes/selected_columns.rs
diff --git a/crates/store/re_types/src/datatypes/annotation_info.rs b/crates/store/re_types/src/datatypes/annotation_info.rs
diff --git a/crates/store/re_types/src/datatypes/tensor_dimension.rs b/crates/store/re_types/src/datatypes/tensor_dimension.rs
diff --git a/crates/store/re_types/src/datatypes/utf8pair.rs b/crates/store/re_types/src/datatypes/utf8pair.rs
diff --git a/crates/store/re_types/src/testing/components/affix_fuzzer10.rs b/crates/store/re_types/src/testing/components/affix_fuzzer10.rs
diff --git a/crates/store/re_types/src/testing/components/affix_fuzzer12.rs b/crates/store/re_types/src/testing/components/affix_fuzzer12.rs
diff --git a/crates/store/re_types/src/testing/components/affix_fuzzer13.rs b/crates/store/re_types/src/testing/components/affix_fuzzer13.rs
diff --git a/crates/store/re_types/src/testing/components/affix_fuzzer9.rs b/crates/store/re_types/src/testing/components/affix_fuzzer9.rs
diff --git a/crates/store/re_types/src/testing/datatypes/affix_fuzzer1.rs b/crates/store/re_types/src/testing/datatypes/affix_fuzzer1.rs