Skip to content

Commit

Permalink
Lock the torch version consistently in pixi.toml and our examples (#6137
Browse files Browse the repository at this point in the history
)

### What
During nightly:
```
pixi run -e wheel-test build-examples install --channel nightly
```
was causing torch to get upgraded to 2.3 alongside torchvision 0.18.

However, the next pixi invocation would then repair torch back to the
2.2.2 version from the lockfile, leading to a torch/torchvision version
mismatch.

Locking the version in the relevant places to keep this from happening.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6137?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6137?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6137)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
  • Loading branch information
jleibs authored Apr 26, 2024
1 parent 2ff6a44 commit 33ec179
Show file tree
Hide file tree
Showing 6 changed files with 2,173 additions and 2,171 deletions.
2 changes: 1 addition & 1 deletion examples/python/controlnet/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies = [
"pillow",
"diffusers==0.27.2",
"numpy",
"torch",
"torch==2.2.2", # This must match the version captured in pixi.toml
"transformers",
"rerun-sdk",
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies = [
"requests>=2.31,<3",
"rerun-sdk",
"scipy",
"torch>1.13.0",
"torch==2.2.2", # This must match the version captured in pixi.toml
"transformers>=4.26.0",
]

Expand Down
2 changes: 1 addition & 1 deletion examples/python/detect_and_track_objects/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies = [
"requests>=2.31,<3",
"rerun-sdk",
"timm==0.9.11",
"torch>=1.13.0",
"torch==2.2.2", # This must match the version captured in pixi.toml
"transformers",
]

Expand Down
2 changes: 1 addition & 1 deletion examples/python/segment_anything_model/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies = [
"opencv-python",
"requests>=2.31,<3",
"rerun-sdk",
"torch",
"torch==2.2.2", # This must match the version captured in pixi.toml
"torchvision",
"tqdm",
]
Expand Down
Loading

0 comments on commit 33ec179

Please sign in to comment.