Skip to content

Commit

Permalink
Fix visible time range help string
Browse files Browse the repository at this point in the history
  • Loading branch information
abey79 committed Jun 27, 2024
1 parent 401050b commit 3c98dc8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 16 deletions.
3 changes: 2 additions & 1 deletion crates/re_selection_panel/src/defaults_ui.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ fn active_default_ui(
.get_by_identifier(*visualizer_identifier)
else {
re_log::warn!(
"Failed to resolve visualizer identifier {visualizer_identifier}, to a visualizer implementation"
"Failed to resolve visualizer identifier {visualizer_identifier}, to a \
visualizer implementation"
);
continue;
};
Expand Down
21 changes: 6 additions & 15 deletions crates/re_selection_panel/src/visible_time_range_ui.rs
Original file line number Diff line number Diff line change
Expand Up @@ -176,27 +176,18 @@ fn query_range_ui(
let time_type = time_ctrl.timeline().typ();

let mut interacting_with_controls = false;
let markdown = format!(
"# Visible time range\n
let markdown = "# Visible time range\n
This feature controls the time range used to display data in the space view.
The settings are inherited from the parent entity or enclosing space view if not overridden.
Visible time range properties are stored separately for each _type_ of timelines. They may differ \
depending on whether the current timeline is temporal or a sequence. The current settings apply to \
all _{}_ timelines.
Notes that the data current as of the time range starting time is included.",
match time_type {
TimeType::Time => "temporal",
TimeType::Sequence => "sequence",
}
);
Notes:
- The settings are inherited from the parent entity or enclosing space view if not overridden.
- Visible time range properties are stored on a per-timeline basis.
- The data current as of the time range starting time is included.";

let collapsing_response = ui
.section_collapsing_header("Visible time range")
.default_open(false)
.help_markdown(&markdown)
.help_markdown(markdown)
.show(ui, |ui| {
ui.horizontal(|ui| {
ui.re_radio_value(has_individual_time_range, false, "Default")
Expand Down

0 comments on commit 3c98dc8

Please sign in to comment.