Skip to content

Commit

Permalink
Remove outdated comment on uuid not being set on recording_id - it is!
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf committed Mar 18, 2024
1 parent 9f9aad8 commit 565e5e8
Show file tree
Hide file tree
Showing 18 changed files with 9 additions and 34 deletions.
9 changes: 9 additions & 0 deletions test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import rerun as rr

rr.init("rerun_example_bug", spawn=True)
rr.set_time_sequence("frame_nr", 0)

rr.log("boxes3d", rr.Boxes3D(centers=[[0, 0, 0], [1, 1.5, 1.15], [3, 2, 1]], half_sizes=[0.5, 1, 0.5] * 3))
rr.log("boxes2d", rr.Boxes2D(centers=[[0, 0], [1.3, 0.5], [3, 2]], half_sizes=[0.5, 1] * 3))
rr.log("text_logs", rr.TextLog("Hello, world!", level=rr.TextLogLevel.INFO))
rr.log("points2d", rr.Points2D([[0, 0], [1, 1], [3, 2]], labels=["a", "b", "c"]))
2 changes: 0 additions & 2 deletions tests/python/release_checklist/check_annotations.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ def log_annotations() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
2 changes: 0 additions & 2 deletions tests/python/release_checklist/check_container_hierarchy.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
2 changes: 0 additions & 2 deletions tests/python/release_checklist/check_focus.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ def log_some_space_views() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
2 changes: 0 additions & 2 deletions tests/python/release_checklist/check_heuristics_2d.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ def log_images() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ def log_3d_scene() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

rr.log("boxes3d", rr.Boxes3D(centers=[[0, 0, 0], [1, 1.5, 1.15], [3, 2, 1]], half_sizes=[0.5, 1, 0.5] * 3))
Expand Down
2 changes: 0 additions & 2 deletions tests/python/release_checklist/check_hover_select_reset.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ def log_points_2d() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ def log_spatial() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
2 changes: 0 additions & 2 deletions tests/python/release_checklist/check_plot_overrides.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ def log_plots() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down
2 changes: 0 additions & 2 deletions tests/python/release_checklist/check_scalar_clears.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ def log_plots() -> None:


def run(args: Namespace) -> None:
# TODO(cmc): I have no idea why this works without specifying a `recording_id`, but
# I'm not gonna rely on it anyway.
rr.script_setup(args, f"{os.path.basename(__file__)}", recording_id=uuid4())

log_readme()
Expand Down

0 comments on commit 565e5e8

Please sign in to comment.