Skip to content

Commit

Permalink
Fix logged obb being displayed with half of the requested size (#1749)
Browse files Browse the repository at this point in the history
  • Loading branch information
BenjaminDev authored Apr 1, 2023
1 parent 1e84aa5 commit 731d941
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ impl Boxes3DPart {
let color =
annotation_info.color(color.map(move |c| c.to_array()).as_ref(), default_color);

let scale = glam::Vec3::from(half_size);
let scale = glam::Vec3::from(half_size) * 2.0;
let rot = rotation.map(glam::Quat::from).unwrap_or_default();
let tran = position.map_or(glam::Vec3::ZERO, glam::Vec3::from);
let transform = glam::Affine3A::from_scale_rotation_translation(scale, rot, tran);
Expand Down

1 comment on commit 731d941

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: 731d941 Previous: 1e84aa5 Ratio
arrow2_convert/serialize/primitive/instances=100000/arrow2_convert 410308 ns/iter (± 6427) 413783 ns/iter (± 431) 0.99
arrow2_convert/serialize/primitive/instances=100000/arrow2/from_values 19189 ns/iter (± 264) 19536 ns/iter (± 90) 0.98
arrow2_convert/serialize/primitive/instances=100000/arrow2/from_vec 18837 ns/iter (± 275) 19223 ns/iter (± 53) 0.98
arrow2_convert/deserialize/primitive/instances=100000/arrow2_convert 96526 ns/iter (± 1150) 96275 ns/iter (± 172) 1.00
arrow2_convert/deserialize/primitive/instances=100000/arrow2/validity_checks 203994 ns/iter (± 2029) 207263 ns/iter (± 312) 0.98
arrow2_convert/deserialize/primitive/instances=100000/arrow2/validity_bypass 57785 ns/iter (± 170) 58066 ns/iter (± 73) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 10343064 ns/iter (± 246058) 10145102 ns/iter (± 352522) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=0 12249490 ns/iter (± 415991) 12048569 ns/iter (± 447633) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2 11958824 ns/iter (± 723321) 12051372 ns/iter (± 855402) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=32 10442893 ns/iter (± 378615) 11358128 ns/iter (± 421011) 0.92
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2048 10158891 ns/iter (± 433143) 10901296 ns/iter (± 419678) 0.93
datastore/num_rows=1000/num_instances=1000/packed=true/insert/default 10323251 ns/iter (± 380701) 11733745 ns/iter (± 829902) 0.88
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=0 12217243 ns/iter (± 520057) 14016063 ns/iter (± 795729) 0.87
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2 11962435 ns/iter (± 558956) 14955978 ns/iter (± 1336712) 0.80
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=32 11138464 ns/iter (± 396722) 12090433 ns/iter (± 874399) 0.92
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2048 10181662 ns/iter (± 389992) 11837369 ns/iter (± 869336) 0.86
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 1793 ns/iter (± 25) 1850 ns/iter (± 16) 0.97
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=0 1830 ns/iter (± 27) 1874 ns/iter (± 2) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2 1832 ns/iter (± 23) 1856 ns/iter (± 0) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=32 1820 ns/iter (± 26) 1863 ns/iter (± 1) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2048 1821 ns/iter (± 27) 1845 ns/iter (± 2) 0.99
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/default 1831 ns/iter (± 33) 1861 ns/iter (± 18) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=0 1841 ns/iter (± 25) 1862 ns/iter (± 0) 0.99
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2 1850 ns/iter (± 27) 1856 ns/iter (± 1) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=32 1843 ns/iter (± 24) 1870 ns/iter (± 3) 0.99
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2048 1828 ns/iter (± 24) 1868 ns/iter (± 1) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 276 ns/iter (± 3) 279 ns/iter (± 0) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 422 ns/iter (± 5) 434 ns/iter (± 0) 0.97
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=0 273 ns/iter (± 3) 280 ns/iter (± 0) 0.97
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=0 428 ns/iter (± 5) 443 ns/iter (± 1) 0.97
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2 275 ns/iter (± 3) 281 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2 437 ns/iter (± 5) 444 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=32 275 ns/iter (± 3) 280 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=32 430 ns/iter (± 6) 439 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2048 274 ns/iter (± 4) 280 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2048 423 ns/iter (± 5) 437 ns/iter (± 0) 0.97
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/default 274 ns/iter (± 3) 279 ns/iter (± 1) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/default 424 ns/iter (± 5) 435 ns/iter (± 0) 0.97
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=0 274 ns/iter (± 3) 281 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=0 435 ns/iter (± 5) 442 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2 278 ns/iter (± 4) 281 ns/iter (± 0) 0.99
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2 432 ns/iter (± 6) 444 ns/iter (± 0) 0.97
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=32 273 ns/iter (± 3) 280 ns/iter (± 0) 0.97
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=32 427 ns/iter (± 6) 439 ns/iter (± 0) 0.97
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2048 275 ns/iter (± 4) 280 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2048 425 ns/iter (± 6) 435 ns/iter (± 0) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 10752330 ns/iter (± 411952) 13809707 ns/iter (± 865890) 0.78
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=0 2182961 ns/iter (± 21243) 2203027 ns/iter (± 47911) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2 2130683 ns/iter (± 22110) 2168216 ns/iter (± 46671) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=32 1860838 ns/iter (± 21077) 1875647 ns/iter (± 11106) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2048 1845662 ns/iter (± 15458) 1883866 ns/iter (± 10031) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/range/default 10462736 ns/iter (± 577240) 10400072 ns/iter (± 431216) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=0 2103385 ns/iter (± 19106) 2194440 ns/iter (± 11960) 0.96
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2 2075487 ns/iter (± 20604) 2122026 ns/iter (± 5662) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=32 1804672 ns/iter (± 20187) 1849348 ns/iter (± 9485) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2048 1823620 ns/iter (± 18059) 1820217 ns/iter (± 11183) 1.00
mono_points_arrow/generate_message_bundles 43260194 ns/iter (± 1005004) 42867912 ns/iter (± 881100) 1.01
mono_points_arrow/generate_messages 179520051 ns/iter (± 2470426) 164790626 ns/iter (± 1127918) 1.09
mono_points_arrow/encode_log_msg 219339638 ns/iter (± 1476377) 210861818 ns/iter (± 998326) 1.04
mono_points_arrow/encode_total 440252153 ns/iter (± 2760339) 416349558 ns/iter (± 2684064) 1.06
mono_points_arrow/decode_log_msg 263740553 ns/iter (± 2072629) 254511216 ns/iter (± 1527236) 1.04
mono_points_arrow/decode_message_bundles 94875201 ns/iter (± 1292781) 85936376 ns/iter (± 973463) 1.10
mono_points_arrow/decode_total 358081485 ns/iter (± 2638856) 339472936 ns/iter (± 2078519) 1.05
mono_points_arrow_batched/generate_message_bundles 31338943 ns/iter (± 1429791) 39083235 ns/iter (± 1369007) 0.80
mono_points_arrow_batched/generate_messages 8170055 ns/iter (± 690173) 11961378 ns/iter (± 942207) 0.68
mono_points_arrow_batched/encode_log_msg 1756504 ns/iter (± 17284) 1785505 ns/iter (± 8123) 0.98
mono_points_arrow_batched/encode_total 44816011 ns/iter (± 1746379) 52791770 ns/iter (± 1654431) 0.85
mono_points_arrow_batched/decode_log_msg 976277 ns/iter (± 5357) 986530 ns/iter (± 8005) 0.99
mono_points_arrow_batched/decode_message_bundles 16445757 ns/iter (± 983011) 21011125 ns/iter (± 587571) 0.78
mono_points_arrow_batched/decode_total 18159103 ns/iter (± 1113770) 21932697 ns/iter (± 577379) 0.83
batch_points_arrow/generate_message_bundles 280199 ns/iter (± 3113) 288944 ns/iter (± 638) 0.97
batch_points_arrow/generate_messages 7497 ns/iter (± 89) 7657 ns/iter (± 12) 0.98
batch_points_arrow/encode_log_msg 384888 ns/iter (± 3635) 396846 ns/iter (± 2785) 0.97
batch_points_arrow/encode_total 681864 ns/iter (± 8286) 704820 ns/iter (± 3761) 0.97
batch_points_arrow/decode_log_msg 339360 ns/iter (± 2724) 340736 ns/iter (± 2317) 1.00
batch_points_arrow/decode_message_bundles 2855 ns/iter (± 30) 2893 ns/iter (± 3) 0.99
batch_points_arrow/decode_total 346776 ns/iter (± 1945) 347903 ns/iter (± 1754) 1.00
arrow_mono_points/insert 6802765507 ns/iter (± 28220893) 6088436739 ns/iter (± 56078824) 1.12
arrow_mono_points/query 1716591 ns/iter (± 22023) 1885234 ns/iter (± 56053) 0.91
arrow_batch_points/insert 2973626 ns/iter (± 33957) 3016247 ns/iter (± 37425) 0.99
arrow_batch_points/query 16562 ns/iter (± 201) 16977 ns/iter (± 18) 0.98
arrow_batch_vecs/insert 42046 ns/iter (± 613) 43603 ns/iter (± 78) 0.96
arrow_batch_vecs/query 523611 ns/iter (± 7056) 535280 ns/iter (± 260) 0.98
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.