Skip to content

Commit

Permalink
missed a couple
Browse files Browse the repository at this point in the history
  • Loading branch information
teh-cmc committed Dec 18, 2022
1 parent 9091e29 commit af046b5
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions crates/re_arrow_store/src/store_write.rs
Original file line number Diff line number Diff line change
Expand Up @@ -735,8 +735,8 @@ impl ComponentTable {
"allocating new component bucket, previous one overflowed"
);

// Retire currently active bucket.
active_bucket.retire();
// Archive currently active bucket.
active_bucket.archive();

let row_offset = active_bucket.row_offset.as_u64() + len;
self.buckets.push_back(ComponentBucket::new(
Expand Down Expand Up @@ -841,13 +841,13 @@ impl ComponentBucket {
self.chunks.len() as u64 - 1
}

/// Retires the bucket as a new one is about to take its place.
/// Archives the bucket as a new one is about to take its place.
///
/// This is a good opportunity to run compaction and other maintenance related tasks.
pub fn retire(&mut self) {
pub fn archive(&mut self) {
debug_assert!(
!self.archived,
"retiring an already archived bucket, something is likely wrong"
"achiving an already archived bucket, something is likely wrong"
);

// Chunk compaction
Expand Down

1 comment on commit af046b5

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: af046b5 Previous: 5e6b997 Ratio
datastore/batch/rects/insert 212482 ns/iter (± 539) 334769 ns/iter (± 674) 0.63
datastore/batch/rects/query 678 ns/iter (± 0) 713 ns/iter (± 7) 0.95
obj_mono_points/insert 885577365 ns/iter (± 6430427) 983915521 ns/iter (± 16948687) 0.90
obj_mono_points/query 343899 ns/iter (± 3126) 364808 ns/iter (± 6416) 0.94
obj_batch_points/insert 87848809 ns/iter (± 357641) 97648510 ns/iter (± 760762) 0.90
obj_batch_points/query 11305 ns/iter (± 11) 11362 ns/iter (± 11) 0.99
obj_batch_points_sequential/insert 23205983 ns/iter (± 126126) 24115913 ns/iter (± 51046) 0.96
obj_batch_points_sequential/query 7910 ns/iter (± 15) 7784 ns/iter (± 16) 1.02
arrow_mono_points/insert 28267656 ns/iter (± 1296475) 41764631 ns/iter (± 1209988) 0.68
arrow_mono_points/query 733388 ns/iter (± 4137) 736907 ns/iter (± 1501) 1.00
arrow_batch_points/insert 133493 ns/iter (± 485) 207929 ns/iter (± 581) 0.64
arrow_batch_points/query 11531 ns/iter (± 46) 11544 ns/iter (± 37) 1.00
obj_batch_points_sequential/Tuid::random 37 ns/iter (± 0) 38 ns/iter (± 0) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.