Skip to content

Commit

Permalink
Fix disconnected space APIs in Python SDK (#2832)
Browse files Browse the repository at this point in the history
The component name is `rerun.disconnected_space`, not
`rerun.disconnect_transform`.

This will be checked by roundtrip tests in the archetype-based APIs.

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2832) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2832)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Ffix_disconnected_space/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Ffix_disconnected_space/examples)
  • Loading branch information
teh-cmc authored Jul 26, 2023
1 parent 20a6179 commit b0a1793
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rerun_py/rerun_sdk/rerun/log/transform.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def log_unknown_transform(
recording = RecordingStream.to_native(recording)

instanced: dict[str, Any] = {}
instanced["rerun.disconnected_transform"] = DisconnectedSpaceArray.single()
instanced["rerun.disconnected_space"] = DisconnectedSpaceArray.single()
bindings.log_arrow_msg(entity_path, components=instanced, timeless=timeless, recording=recording)


Expand Down Expand Up @@ -193,7 +193,7 @@ def log_disconnected_space(
recording = RecordingStream.to_native(recording)

instanced: dict[str, Any] = {}
instanced["rerun.disconnected_transform"] = DisconnectedSpaceArray.single()
instanced["rerun.disconnected_space"] = DisconnectedSpaceArray.single()
bindings.log_arrow_msg(entity_path, components=instanced, timeless=timeless, recording=recording)


Expand Down

1 comment on commit b0a1793

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.

Benchmark suite Current: b0a1793 Previous: 20a6179 Ratio
batch_points_arrow/generate_message_bundles 237471 ns/iter (± 252) 159927 ns/iter (± 306) 1.48

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.