Skip to content

Commit

Permalink
Fix typos from new version of typos (#5735)
Browse files Browse the repository at this point in the history
### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5735/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5735/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5735/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5735)
- [Docs
preview](https://rerun.io/preview/934361bf457e165e3a35a512e7076a569b8008af/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/934361bf457e165e3a35a512e7076a569b8008af/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
  • Loading branch information
emilk authored Apr 2, 2024
1 parent 31d5c54 commit c504eba
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 14 deletions.
24 changes: 18 additions & 6 deletions .typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ extend-exclude = [
".typos.toml",
"crates/re_ui/data/design_tokens.json",
"crates/re_ui/src/design_tokens.rs",
"docs/cspell.json",
"examples/assets",
"rerun_cpp/src/rerun/third_party/cxxopts.hpp",
]
Expand Down Expand Up @@ -109,6 +110,7 @@ saviour = "savior"
savour = "savor"
sceptical = "skeptical"
sceptre = "scepter"
FUL = "FUL" # forward-up-left coordinate system
sepulchre = "sepulcher"
serialisation = "serialization"
serialise = "serialize"
Expand All @@ -127,8 +129,10 @@ tonne = "ton"
travelogue = "travelog"
tumour = "tumor"
valour = "valor"
opf = "opf" # Open Photogrammetry Format (OPF) file
vaporise = "vaporize"
vigour = "vigor"
ws = "ws" # web-sockets, as in "ws://…"

# null-terminated is the name of the wikipedia article!
# https://en.wikipedia.org/wiki/Null-terminated_string
Expand All @@ -137,9 +141,17 @@ zeroterminated = "null-terminated"
zero-terminated = "null-terminated"

[default]
# Work around for typos inside of hashes. These show up inside of ipynb.
# e.g. "f4e1caf9" -> `caf` should be `calf`
# Specifically limit ourselves to exactly 8 chars in a quoted string, or
# 16 character hashses following a leading underscore.
# Just don't spell "defaced" wrong.
extend-ignore-re = ["\"[a-f0-9]{8}\"", "_[a-f0-9]{16}"]
extend-ignore-re = [
# Work around for typos inside of hashes. These show up inside of ipynb.
# e.g. "f4e1caf9" -> `caf` should be `calf`
# Specifically limit ourselves to exactly 8 chars in a quoted string, or
# 16 character hashses following a leading underscore.
# Just don't spell "defaced" wrong.
"\"[a-f0-9]{8}\"",
"_[a-f0-9]{16}",


"np.arange", # numpy spells "arrange" wrong
"phc_[a-zA-Z0-9]*", # Posthog public key
"PNG.?", # Workaround for https://github.com/crate-ci/typos/issues/967
]
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ cargo run -p rerun -- --help

## Tools

We use the [`just`](https://github.com/casey/just) command runner tool for repository automation. See [here](https://github.com/casey/just#installation) for installation instructions. To see available automations, use `just --list`.
We use the [`just`](https://github.com/casey/just) command runner tool for repository automation. See [here](https://github.com/casey/just#installation) for installation instructions. To see available automation, use `just --list`.

We use [cargo cranky](https://github.com/ericseppanen/cargo-cranky) and specify our clippy lints in [`Cranky.toml`](Cranky.toml). Usage: `cargo cranky`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#import <../screen_triangle_vertex.wgsl>

fn compute_pixel_coords(center_coord: vec2i, unnormalized_edge_pos_a_and_b: vec4f, num_edges_a_and_b: vec2f) -> vec4f {
// Normalize edges ans get range from [0, 1] to [-0.5, 0.5].
// Normalize edges and get range from [0, 1] to [-0.5, 0.5].
let edge_pos_a_and_b = unnormalized_edge_pos_a_and_b / num_edges_a_and_b.xxyy - vec4f(0.5);

// We're outputting pixel coordinates (0-res) instead of texture coordinates (0-1).
Expand Down
2 changes: 1 addition & 1 deletion crates/re_types/src/components/view_coordinates_ext.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ impl ViewCoordinates {
Self([x as u8, y as u8, z as u8])
}

/// Choses a coordinate system based on just an up-axis.
/// Chooses a coordinate system based on just an up-axis.
pub fn from_up_and_handedness(up: SignedAxis3, handedness: Handedness) -> Self {
use ViewDir::{Back, Down, Forward, Right, Up};
match handedness {
Expand Down
2 changes: 1 addition & 1 deletion crates/re_types_builder/src/codegen/cpp/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ fn generate_object_files(
///
/// Additionally, picks up all includes files that aren't including the header itself.
///
/// Returns what to inject, and what to repalce `HEADER_EXTENSION_TOKEN` with at the end.
/// Returns what to inject, and what to replace `HEADER_EXTENSION_TOKEN` with at the end.
fn hpp_type_extensions(
folder_path: &Utf8Path,
filename_stem: &str,
Expand Down
4 changes: 2 additions & 2 deletions crates/re_ui/examples/re_ui_example.rs
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ impl eframe::App for ExampleApp {
// no need to extend `ui.max_rect()` as the enclosing frame doesn't have margins
ui.set_clip_rect(ui.max_rect());

egui::TopBottomPanel::top("left_panel_tio_bar")
egui::TopBottomPanel::top("left_panel_top_bar")
.exact_height(re_ui::ReUi::title_bar_height())
.frame(egui::Frame {
inner_margin: egui::Margin::symmetric(re_ui::ReUi::view_padding(), 0.0),
Expand Down Expand Up @@ -830,7 +830,7 @@ mod hierarchical_drag_and_drop {
target_position_index: usize,
},

/// Specify the currently identifed target container to be highlighted.
/// Specify the currently identified target container to be highlighted.
HighlightTargetContainer(ItemId),
}

Expand Down
2 changes: 1 addition & 1 deletion crates/re_viewer/src/screenshotter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pub struct Screenshotter {
#[cfg(not(target_arch = "wasm32"))]
#[must_use]
pub struct ScreenshotterOutput {
/// If true, the screenshotter was told at startup to quit after its donw.
/// If true, the screenshotter was told at startup to quit after it's done.
pub quit: bool,
}

Expand Down
2 changes: 1 addition & 1 deletion rerun_cpp/download_and_build_arrow.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function(download_and_build_arrow)
GIT_REPOSITORY https://github.com/apache/arrow.git
GIT_TAG apache-arrow-10.0.1
GIT_SHALLOW ON
GIT_PROGRESS OFF # Git progress sounds like a nice idea but is in practive very spammy.
GIT_PROGRESS OFF # Git progress sounds like a nice idea but is in practice very spammy.

# LOG_X ON means that the output of the command will
# be logged to a file _instead_ of printed to the console.
Expand Down

0 comments on commit c504eba

Please sign in to comment.