Skip to content

Commit

Permalink
Leave a TODO about radius
Browse files Browse the repository at this point in the history
  • Loading branch information
@jleibs
jleibs committed Dec 18, 2022
1 parent 144fd0f commit e81937a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions crates/re_query/benches/obj_query_benchmark.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ fn query_and_visit(store: &mut DataStore, paths: &[ObjPath]) -> Vec<Point> {

let mut points = Vec::with_capacity(NUM_POINTS as _);

// TODO(jleibs): Add Radius once we have support for it in field_types
for path in paths.iter() {
if let Ok(df) = query_entity_with_primary(
store,
Expand Down

2 comments on commit e81937a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: e81937a Previous: 504f347 Ratio
datastore/batch/rects/insert 1713541 ns/iter (± 40868) 400422 ns/iter (± 896) 4.28
datastore/batch/rects/query 1398 ns/iter (± 7) 1315 ns/iter (± 2) 1.06
obj_mono_points/insert 866847444 ns/iter (± 4808204) 876003782 ns/iter (± 3398748) 0.99
obj_mono_points/query 328600 ns/iter (± 1416) 340420 ns/iter (± 3576) 0.97
obj_batch_points/insert 90872184 ns/iter (± 444529) 88308190 ns/iter (± 443829) 1.03
obj_batch_points/query 11179 ns/iter (± 52) 11374 ns/iter (± 38) 0.98
obj_batch_points_sequential/insert 22590384 ns/iter (± 297256) 22942042 ns/iter (± 94380) 0.98
obj_batch_points_sequential/query 5731 ns/iter (± 33) 5697 ns/iter (± 18) 1.01
arrow_mono_points/insert 284741134 ns/iter (± 1004541)
arrow_mono_points/query 61234420 ns/iter (± 1810774)
arrow_batch_points/insert 974860 ns/iter (± 3083)
arrow_batch_points/query 625322 ns/iter (± 21919)
obj_batch_points_sequential/Tuid::random 37 ns/iter (± 0) 37 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: e81937a Previous: 504f347 Ratio
datastore/batch/rects/insert 1713541 ns/iter (± 40868) 400422 ns/iter (± 896) 4.28

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.