Skip to content

Commit

Permalink
back to defaults :>
Browse files Browse the repository at this point in the history
  • Loading branch information
@teh-cmc
teh-cmc committed Apr 3, 2023
1 parent 113b09e commit f07b8d8
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions crates/re_data_store/src/log_db.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ impl Default for EntityDb {
tree: crate::EntityTree::root(),
data_store: re_arrow_store::DataStore::new(
InstanceKey::name(),
DataStoreConfig {
// TODO: sorting and splitting is now pretty costly
indexed_bucket_num_rows: 64,
..Default::default()
},
DataStoreConfig::default(),
),
}
}
Expand Down

2 comments on commit f07b8d8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: f07b8d8 Previous: 29a13ea Ratio
arrow2/size_bytes/primitive/rows=10000/instances=100/array 145859 ns/iter (± 776) 148300 ns/iter (± 743) 0.98
arrow2/size_bytes/primitive/rows=10000/instances=100/vec 5912 ns/iter (± 21) 3288 ns/iter (± 21) 1.80
arrow2/size_bytes/primitive/rows=10000/instances=100/vec/erased 17719 ns/iter (± 5) 17720 ns/iter (± 99) 1.00
arrow2/size_bytes/struct/rows=10000/instances=100/array 481992 ns/iter (± 3829) 501737 ns/iter (± 4053) 0.96
arrow2/size_bytes/struct/rows=10000/instances=100/vec 5911 ns/iter (± 2) 3272 ns/iter (± 30) 1.81
arrow2/size_bytes/struct/rows=10000/instances=100/vec/erased 17720 ns/iter (± 7) 17571 ns/iter (± 149) 1.01
arrow2/size_bytes/struct_large/rows=10000/instances=100/array 4225305 ns/iter (± 250721) 3611445 ns/iter (± 295981) 1.17
arrow2/size_bytes/struct_large/rows=10000/instances=100/vec 3984 ns/iter (± 193) 3934 ns/iter (± 40) 1.01
arrow2/size_bytes/struct_large/rows=10000/instances=100/vec/erased 17723 ns/iter (± 6) 17612 ns/iter (± 210) 1.01
arrow2/erased_clone/primitive/rows=10000/instances=100/cell/arc_erased 238404 ns/iter (± 533) 770047 ns/iter (± 4046) 0.31
arrow2/erased_clone/primitive/rows=10000/instances=100/cell/wrapped_in_arc 192402 ns/iter (± 143) 189442 ns/iter (± 1755) 1.02
arrow2/erased_clone/primitive/rows=10000/instances=100/array 796062 ns/iter (± 2773) 741950 ns/iter (± 3757) 1.07
arrow2/erased_clone/primitive/rows=10000/instances=100/array/downcast_first 392227 ns/iter (± 1010) 357577 ns/iter (± 3832) 1.10
arrow2/erased_clone/primitive/rows=10000/instances=100/vec/full_copy 1037018 ns/iter (± 16379) 1020624 ns/iter (± 14264) 1.02
arrow2/erased_clone/primitive/rows=10000/instances=100/vec/wrapped_in_arc 127149 ns/iter (± 197) 127077 ns/iter (± 870) 1.00
arrow2/erased_clone/struct/rows=10000/instances=100/cell/arc_erased 375772 ns/iter (± 753) 4214637 ns/iter (± 105458) 0.0891588053727996
arrow2/erased_clone/struct/rows=10000/instances=100/cell/wrapped_in_arc 281182 ns/iter (± 1122) 279796 ns/iter (± 2056) 1.00
arrow2/erased_clone/struct/rows=10000/instances=100/array 4501678 ns/iter (± 218325) 4120116 ns/iter (± 61539) 1.09
arrow2/erased_clone/struct/rows=10000/instances=100/array/downcast_first 3772258 ns/iter (± 54546) 3550125 ns/iter (± 36481) 1.06
arrow2/erased_clone/struct/rows=10000/instances=100/vec/full_copy 1367835 ns/iter (± 65199) 1283442 ns/iter (± 24136) 1.07
arrow2/erased_clone/struct/rows=10000/instances=100/vec/wrapped_in_arc 126996 ns/iter (± 432) 126538 ns/iter (± 1372) 1.00
arrow2/erased_clone/struct_large/rows=10000/instances=100/cell/arc_erased 191419 ns/iter (± 582) 53470183 ns/iter (± 925361) 0.0035799204203209854
arrow2/erased_clone/struct_large/rows=10000/instances=100/cell/wrapped_in_arc 178316 ns/iter (± 188) 168703 ns/iter (± 1263) 1.06
arrow2/erased_clone/struct_large/rows=10000/instances=100/array 47283402 ns/iter (± 329857) 52087011 ns/iter (± 883710) 0.91
arrow2/erased_clone/struct_large/rows=10000/instances=100/array/downcast_first 46204840 ns/iter (± 568450) 50096180 ns/iter (± 847690) 0.92
arrow2/erased_clone/struct_large/rows=10000/instances=100/vec/full_copy 4807429 ns/iter (± 96012) 5413612 ns/iter (± 312427) 0.89
arrow2/erased_clone/struct_large/rows=10000/instances=100/vec/wrapped_in_arc 128214 ns/iter (± 64) 126747 ns/iter (± 824) 1.01
arrow2_convert/serialize/primitive/instances=100000/arrow2_convert 371577 ns/iter (± 474) 415436 ns/iter (± 4284) 0.89
arrow2_convert/serialize/primitive/instances=100000/arrow2/from_values 19430 ns/iter (± 50) 19542 ns/iter (± 384) 0.99
arrow2_convert/serialize/primitive/instances=100000/arrow2/from_vec 19273 ns/iter (± 33) 19669 ns/iter (± 207) 0.98
arrow2_convert/deserialize/primitive/instances=100000/arrow2_convert 95931 ns/iter (± 213) 96288 ns/iter (± 508) 1.00
arrow2_convert/deserialize/primitive/instances=100000/arrow2/validity_checks 159403 ns/iter (± 237) 160674 ns/iter (± 1112) 0.99
arrow2_convert/deserialize/primitive/instances=100000/arrow2/validity_bypass 58333 ns/iter (± 73) 58643 ns/iter (± 241) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 2441352 ns/iter (± 29569) 10638674 ns/iter (± 721417) 0.23
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=0 3392186 ns/iter (± 46761) 12800212 ns/iter (± 452803) 0.27
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2 3414180 ns/iter (± 43642) 12123770 ns/iter (± 638739) 0.28
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=32 2671023 ns/iter (± 29313) 10600992 ns/iter (± 454300) 0.25
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2048 2414547 ns/iter (± 29792) 10847035 ns/iter (± 710500) 0.22
datastore/num_rows=1000/num_instances=1000/packed=true/insert/default 2304811 ns/iter (± 17510) 10224985 ns/iter (± 403984) 0.23
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=0 3327011 ns/iter (± 33483) 11999563 ns/iter (± 580359) 0.28
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2 3368095 ns/iter (± 47434) 11807113 ns/iter (± 596072) 0.29
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=32 2621769 ns/iter (± 29175) 10482180 ns/iter (± 413209) 0.25
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2048 2341808 ns/iter (± 15129) 10184170 ns/iter (± 455895) 0.23
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 369 ns/iter (± 5) 1828 ns/iter (± 22) 0.20
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=0 373 ns/iter (± 0) 1834 ns/iter (± 12) 0.20
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2 372 ns/iter (± 0) 1846 ns/iter (± 12) 0.20
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=32 371 ns/iter (± 0) 1818 ns/iter (± 8) 0.20
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2048 368 ns/iter (± 0) 1833 ns/iter (± 6) 0.20
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/default 367 ns/iter (± 4) 1821 ns/iter (± 21) 0.20
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=0 371 ns/iter (± 0) 1843 ns/iter (± 15) 0.20
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2 371 ns/iter (± 1) 1824 ns/iter (± 17) 0.20
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=32 370 ns/iter (± 0) 1847 ns/iter (± 5) 0.20
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2048 367 ns/iter (± 0) 1838 ns/iter (± 20) 0.20
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 258 ns/iter (± 0) 280 ns/iter (± 1) 0.92
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 416 ns/iter (± 0) 437 ns/iter (± 1) 0.95
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=0 259 ns/iter (± 0) 279 ns/iter (± 1) 0.93
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=0 422 ns/iter (± 2) 443 ns/iter (± 1) 0.95
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2 258 ns/iter (± 0) 280 ns/iter (± 0) 0.92
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2 422 ns/iter (± 0) 444 ns/iter (± 1) 0.95
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=32 258 ns/iter (± 0) 281 ns/iter (± 0) 0.92
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=32 422 ns/iter (± 1) 439 ns/iter (± 3) 0.96
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2048 258 ns/iter (± 0) 279 ns/iter (± 0) 0.92
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2048 417 ns/iter (± 0) 435 ns/iter (± 2) 0.96
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/default 258 ns/iter (± 0) 279 ns/iter (± 0) 0.92
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/default 415 ns/iter (± 0) 434 ns/iter (± 1) 0.96
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=0 257 ns/iter (± 0) 279 ns/iter (± 0) 0.92
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=0 421 ns/iter (± 0) 447 ns/iter (± 3) 0.94
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2 259 ns/iter (± 0) 278 ns/iter (± 1) 0.93
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2 427 ns/iter (± 0) 449 ns/iter (± 0) 0.95
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=32 259 ns/iter (± 0) 279 ns/iter (± 0) 0.93
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=32 421 ns/iter (± 0) 439 ns/iter (± 0) 0.96
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2048 258 ns/iter (± 0) 280 ns/iter (± 1) 0.92
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2048 415 ns/iter (± 0) 434 ns/iter (± 1) 0.96
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 2578085 ns/iter (± 44515) 12174288 ns/iter (± 597918) 0.21
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=0 310498 ns/iter (± 370) 2181647 ns/iter (± 27486) 0.14
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2 314211 ns/iter (± 384) 2186675 ns/iter (± 14860) 0.14
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=32 117894 ns/iter (± 261) 1936760 ns/iter (± 12398) 0.06087176521613416
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2048 99129 ns/iter (± 73) 1840328 ns/iter (± 16573) 0.053864854525932336
datastore/num_rows=1000/num_instances=1000/packed=true/range/default 2302562 ns/iter (± 18265) 11722311 ns/iter (± 742657) 0.20
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=0 296407 ns/iter (± 588) 2130938 ns/iter (± 71721) 0.14
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2 295286 ns/iter (± 353) 2154847 ns/iter (± 17490) 0.14
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=32 116075 ns/iter (± 96) 1884472 ns/iter (± 28531) 0.06159550261293349
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2048 98042 ns/iter (± 194) 1830844 ns/iter (± 28354) 0.05355016593439965
vector_ops/sort/instances=10000/smallvec/n=4 12492 ns/iter (± 29) 12359 ns/iter (± 25) 1.01
vector_ops/sort/instances=10000/tinyvec/n=4 9637 ns/iter (± 46) 9661 ns/iter (± 49) 1.00
vector_ops/sort/instances=10000/vec 9645 ns/iter (± 23) 9626 ns/iter (± 33) 1.00
vector_ops/split_off/instances=10000/smallvec/n=4/manual 5534 ns/iter (± 35) 5561 ns/iter (± 19) 1.00
vector_ops/split_off/instances=10000/tinyvec/n=4 2724 ns/iter (± 18) 2740 ns/iter (± 27) 0.99
vector_ops/split_off/instances=10000/tinyvec/n=4/manual 2740 ns/iter (± 7) 2749 ns/iter (± 21) 1.00
vector_ops/split_off/instances=10000/vec 2729 ns/iter (± 10) 2731 ns/iter (± 21) 1.00
vector_ops/split_off/instances=10000/vec/manual 2723 ns/iter (± 28) 2735 ns/iter (± 17) 1.00
vector_ops/swap/instances=10000/smallvec/n=4 32746 ns/iter (± 12) 32763 ns/iter (± 60) 1.00
vector_ops/swap/instances=10000/tinyvec/n=4 18231 ns/iter (± 36) 18283 ns/iter (± 22) 1.00
vector_ops/swap/instances=10000/vec 10230 ns/iter (± 19) 12319 ns/iter (± 47) 0.83
vector_ops/swap_opt/instances=10000/smallvec/n=4 42710 ns/iter (± 41) 42705 ns/iter (± 90) 1.00
vector_ops/swap_opt/instances=10000/tinyvec/n=4 28848 ns/iter (± 35) 28791 ns/iter (± 66) 1.00
vector_ops/swap_opt/instances=10000/vec 19750 ns/iter (± 24) 19818 ns/iter (± 25) 1.00
mono_points_arrow/generate_message_bundles 39671234 ns/iter (± 1215647) 46316431 ns/iter (± 644918) 0.86
mono_points_arrow/generate_messages 162155543 ns/iter (± 1082984) 183382126 ns/iter (± 1497890) 0.88
mono_points_arrow/encode_log_msg 209348439 ns/iter (± 858672) 224379598 ns/iter (± 1031199) 0.93
mono_points_arrow/encode_total 417312752 ns/iter (± 2316939) 452302399 ns/iter (± 1815719) 0.92
mono_points_arrow/decode_log_msg 252579963 ns/iter (± 919571) 270391565 ns/iter (± 1237132) 0.93
mono_points_arrow/decode_message_bundles 87799046 ns/iter (± 676298) 99694109 ns/iter (± 1125172) 0.88
mono_points_arrow/decode_total 336089311 ns/iter (± 1500402) 368423831 ns/iter (± 2140655) 0.91
mono_points_arrow_batched/generate_message_bundles 37170364 ns/iter (± 1013035) 36718603 ns/iter (± 1354639) 1.01
mono_points_arrow_batched/generate_messages 10459978 ns/iter (± 428324) 11364244 ns/iter (± 674006) 0.92
mono_points_arrow_batched/encode_log_msg 1800850 ns/iter (± 5612) 1802197 ns/iter (± 4059) 1.00
mono_points_arrow_batched/encode_total 49586742 ns/iter (± 1166382) 51982074 ns/iter (± 4524698) 0.95
mono_points_arrow_batched/decode_log_msg 981712 ns/iter (± 2414) 991987 ns/iter (± 4324) 0.99
mono_points_arrow_batched/decode_message_bundles 20762627 ns/iter (± 697730) 20640513 ns/iter (± 1463771) 1.01
mono_points_arrow_batched/decode_total 22205122 ns/iter (± 590393) 21075346 ns/iter (± 1540303) 1.05
batch_points_arrow/generate_message_bundles 280692 ns/iter (± 576) 284473 ns/iter (± 1995) 0.99
batch_points_arrow/generate_messages 7523 ns/iter (± 13) 7639 ns/iter (± 13) 0.98
batch_points_arrow/encode_log_msg 382119 ns/iter (± 869) 394503 ns/iter (± 3369) 0.97
batch_points_arrow/encode_total 691869 ns/iter (± 1957) 695338 ns/iter (± 4884) 1.00
batch_points_arrow/decode_log_msg 338351 ns/iter (± 633) 337876 ns/iter (± 1156) 1.00
batch_points_arrow/decode_message_bundles 2984 ns/iter (± 15) 2912 ns/iter (± 13) 1.02
batch_points_arrow/decode_total 345590 ns/iter (± 613) 347168 ns/iter (± 3149) 1.00
arrow_mono_points/insert 1839188655 ns/iter (± 17299011) 6958829824 ns/iter (± 13837782) 0.26
arrow_mono_points/query 1597645 ns/iter (± 7937) 1812590 ns/iter (± 20101) 0.88
arrow_batch_points/insert 715672 ns/iter (± 4139) 2970081 ns/iter (± 36870) 0.24
arrow_batch_points/query 16845 ns/iter (± 15) 16453 ns/iter (± 50) 1.02
arrow_batch_vecs/insert 26575 ns/iter (± 94) 42748 ns/iter (± 203) 0.62
arrow_batch_vecs/query 534887 ns/iter (± 487) 506242 ns/iter (± 2723) 1.06
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: f07b8d8 Previous: 29a13ea Ratio
arrow2/size_bytes/primitive/rows=10000/instances=100/vec 5912 ns/iter (± 21) 3288 ns/iter (± 21) 1.80
arrow2/size_bytes/struct/rows=10000/instances=100/vec 5911 ns/iter (± 2) 3272 ns/iter (± 30) 1.81

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.