Skip to content

Commit

Permalink
make reverse argument explicit
Browse files Browse the repository at this point in the history
  • Loading branch information
jleibs committed Dec 18, 2022
1 parent 7c9e999 commit f6e62fb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion crates/re_query/src/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ fn add_instances_and_sort_if_needed(df: &DataFrame) -> Result<DataFrame> {
if df.column(Instance::NAME).is_ok() {
// If we have an InstanceKey column already, make sure that it's sorted.
// TODO(jleibs): can remove this once we have a sort guarantee from the store
Ok(df.sort([Instance::NAME], false)?)
let reverse = false;
Ok(df.sort([Instance::NAME], reverse)?)
} else {
// If we don't have an InstanceKey column, it is implicit, and we generate it
// based on the row-number so we can use this in join-operations.
Expand Down

1 comment on commit f6e62fb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: f6e62fb Previous: 1786633 Ratio
datastore/batch/rects/insert 1686090 ns/iter (± 5801) 1681240 ns/iter (± 9677) 1.00
datastore/batch/rects/query 1336 ns/iter (± 2) 1374 ns/iter (± 1) 0.97
obj_mono_points/insert 867093472 ns/iter (± 5431149) 964918508 ns/iter (± 5783867) 0.90
obj_mono_points/query 336256 ns/iter (± 912) 339432 ns/iter (± 2007) 0.99
obj_batch_points/insert 89659117 ns/iter (± 482983) 99228765 ns/iter (± 513823) 0.90
obj_batch_points/query 11327 ns/iter (± 21) 11212 ns/iter (± 29) 1.01
obj_batch_points_sequential/insert 22150735 ns/iter (± 239250) 23190247 ns/iter (± 311693) 0.96
obj_batch_points_sequential/query 5670 ns/iter (± 7) 5760 ns/iter (± 12) 0.98
arrow_mono_points/insert 284858800 ns/iter (± 390002) 287414576 ns/iter (± 521604) 0.99
arrow_mono_points/query 816136 ns/iter (± 2081) 61832450 ns/iter (± 930251) 0.013199153518904718
arrow_batch_points/insert 988256 ns/iter (± 4742) 966896 ns/iter (± 6516) 1.02
arrow_batch_points/query 12385 ns/iter (± 25) 634483 ns/iter (± 12586) 0.019519829530499636
obj_batch_points_sequential/Tuid::random 37 ns/iter (± 0) 38 ns/iter (± 0) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.