-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch selections should not preview single-element non-splats #1014
Comments
This should be irrelevant now that splats are handled in independent rows? @jleibs |
Nope, still an issue. This snippet is actually runnable:
The selection UI makes it look like all the points should be red, but since the 2nd log-value is not a splat, only the second point is actualy red (which is correct) I think the issue is basically here, where we should explicitly check for a splat instead of a length of 1. |
Annihilate everything related to instance keys. --- - [x] Remove `InstanceKey` - [x] Remove `NumInstances` - [x] Remove explicit/client-side splats - [x] Remove cluster keys and autogenerated cells - [x] Clean up every other little thing related to any of the above - [x] Update batching docs - [x] Check that Kiss-ICP now works smoothly - [x] Check roundtrips - [x] Check `rerun snippets/*.rrd` - [x] Rebase and run checklist - [x] Run full check bot --- Findings (none blocking, not sure any are new -- to be investigated later): - Depth clouds with visible history are broken in a different way than before - `OutOfTreeTransform` might be broken? (see associated snippet) - Does `DisconnectedSpace` even work? (see associated snippet) - Is something wrong with labels when there are lots of instances? --- - Fixes #5303 - Fixes #1014 - Fixes #1777 - Fixes #1793 - Fixes #1893 - Fixes #5685 - Fixes #1014
Although it's not easy to do with our APIs at the moment, it's theoretically possible to log a non-splatted element with a single instance-key.
For example, a future API that allows us to log colors directly:
In this case, color is not a splat, but if you hover on the batch of points in the UI, it will display as if RED applies to the whole batch rather than only applying to the 2nd point.
The text was updated successfully, but these errors were encountered: