Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch selections should not preview single-element non-splats #1014

Closed
jleibs opened this issue Jan 31, 2023 · 3 comments · Fixed by #6104
Closed

Batch selections should not preview single-element non-splats #1014

jleibs opened this issue Jan 31, 2023 · 3 comments · Fixed by #6104
Assignees
Labels
🪳 bug Something isn't working ui concerns graphical user interface

Comments

@jleibs
Copy link
Member

jleibs commented Jan 31, 2023

Although it's not easy to do with our APIs at the moment, it's theoretically possible to log a non-splatted element with a single instance-key.

For example, a future API that allows us to log colors directly:

rr.log_points("points", [[1,2],[3,4]], instance_keys=[1, 2])
rr.log_colors("points", [RED], instance_keys=[2])

In this case, color is not a splat, but if you hover on the batch of points in the UI, it will display as if RED applies to the whole batch rather than only applying to the 2nd point.

@jleibs jleibs added 🪳 bug Something isn't working ui concerns graphical user interface labels Jan 31, 2023
@teh-cmc
Copy link
Member

teh-cmc commented Feb 28, 2023

This should be irrelevant now that splats are handled in independent rows? @jleibs

@jleibs
Copy link
Member Author

jleibs commented Feb 28, 2023

This should be irrelevant now that splats are handled in independent rows? @jleibs

Nope, still an issue. This snippet is actually runnable:

import rerun as rr

rr.init("point_test", spawn=True)
rr.log_points("points", positions=[[1, 2], [3, 4]], identifiers=[1, 2])
rr.log_points("points", positions=None, colors=[[255, 0, 0]], identifiers=[2])

Produces this data UI:
image

The selection UI makes it look like all the points should be red, but since the 2nd log-value is not a splat, only the second point is actualy red (which is correct)

I think the issue is basically here, where we should explicitly check for a splat instead of a length of 1.
https://github.com/rerun-io/rerun/blob/jleibs/tensor_view_without_classic/crates/re_viewer/src/ui/data_ui/component.rs#L52

@teh-cmc
Copy link
Member

teh-cmc commented Mar 21, 2023

Should be fixed by #1619 #1893

@teh-cmc teh-cmc self-assigned this Mar 15, 2024
teh-cmc added a commit that referenced this issue Apr 26, 2024
Annihilate everything related to instance keys.

---


- [x] Remove `InstanceKey`
- [x] Remove `NumInstances`
- [x] Remove explicit/client-side splats
- [x] Remove cluster keys and autogenerated cells
- [x] Clean up every other little thing related to any of the above
- [x] Update batching docs
- [x] Check that Kiss-ICP now works smoothly
- [x] Check roundtrips
- [x] Check `rerun snippets/*.rrd`
- [x] Rebase and run checklist
- [x] Run full check bot

---

Findings (none blocking, not sure any are new -- to be investigated
later):
- Depth clouds with visible history are broken in a different way than
before
- `OutOfTreeTransform` might be broken? (see associated snippet)
- Does `DisconnectedSpace` even work? (see associated snippet)
- Is something wrong with labels when there are lots of instances?

---

- Fixes #5303
- Fixes #1014
- Fixes #1777
- Fixes #1793
- Fixes #1893
- Fixes #5685
- Fixes #1014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants