Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save .rrd from store instead of saving LogMsg:es. #1394

Closed
emilk opened this issue Feb 24, 2023 · 1 comment
Closed

Save .rrd from store instead of saving LogMsg:es. #1394

emilk opened this issue Feb 24, 2023 · 1 comment
Assignees
Labels
🚀 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself 📺 re_viewer affects re_viewer itself

Comments

@emilk
Copy link
Member

emilk commented Feb 24, 2023

Currently the viewer stores all LogMsg:ed it receives in order to be able to save them as a .rrd file.

This leads to a lot of extra memory user, often at 2x or more, since the same data is also stored in the data store.

We need to support:

  • Saving the entire store
  • Saving a time-range of one timeline

We should implement batch ingestion before we work on this, as it affects how data is stored in an .rrd file.

Blocked on:

@teh-cmc
Copy link
Member

teh-cmc commented Mar 9, 2023

Fixed by #1535, which went the other route instead (#1397), for the reasons explained in detail in #1535.

@teh-cmc teh-cmc closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

2 participants