Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re_datastore: support for batched row insertions #589

Closed
teh-cmc opened this issue Dec 17, 2022 · 1 comment
Closed

re_datastore: support for batched row insertions #589

teh-cmc opened this issue Dec 17, 2022 · 1 comment
Labels
⛃ re_datastore affects the datastore itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Dec 17, 2022

While it is possible to insert any number of columns (== components) at once, we currently only support inserting a single row at a time.

While #584 actually lifts this limitation from a public API standpoint (i.e. the caller can now pass many rows of many components to be inserted), internally we are still splitting the batch into single rows and inserting those one by one.

We should think about being able to actually support zero-copy/zero-alloc batched insertions where possible.
In particular, this will need to integrate nicely with the recently added component bucket chunks.

This requires the flatter MsgBundles that have been talked about: we need MsgBundles to be able to carry more than one timepoint in order to insert more than one row!

@teh-cmc teh-cmc added the ⛃ re_datastore affects the datastore itself label Dec 17, 2022
@teh-cmc teh-cmc changed the title re_datastore: support for batch row insertions re_datastore: support for batched row insertions Dec 17, 2022
@teh-cmc
Copy link
Member Author

teh-cmc commented Mar 21, 2023

Superseded by #1619

@teh-cmc teh-cmc closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛃ re_datastore affects the datastore itself
Projects
None yet
Development

No branches or pull requests

1 participant