Better auto-layout of space-views #2139
Labels
enhancement
New feature or request
📺 re_viewer
affects re_viewer itself
ui
concerns graphical user interface
Comments
emilk
added
enhancement
emilk
added a commit
that referenced
this issue
Jun 29, 2023
Closes #2139 ### What This simplifies the auto-layout of space views. We make heavy use of `egui_tiles::Grid`, which is responsive to the current viewport size. This means that space views may move around as you resize window in an effort to keep each one square-ish. In the future we can make `egui_tiles` smarter here and inform it of the desired aspect ratio of each space view. We make an exception for the (common) case of exactly three space views, which doesn't fit nicely in a grid anyways. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested https://demo.rerun.io/pr/2558 <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2558 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/e2ed87c/docs Examples preview: https://rerun.io/preview/e2ed87c/examples <!-- pr-link-docs:end --> ### Testing In order to test this I used the `run_all.py` script and found a bunch of issues with is, so I fixed them.      
emilk
added a commit
that referenced
this issue
Jun 29, 2023
Closes #2139 ### What This simplifies the auto-layout of space views. We make heavy use of `egui_tiles::Grid`, which is responsive to the current viewport size. This means that space views may move around as you resize window in an effort to keep each one square-ish. In the future we can make `egui_tiles` smarter here and inform it of the desired aspect ratio of each space view. We make an exception for the (common) case of exactly three space views, which doesn't fit nicely in a grid anyways. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested https://demo.rerun.io/pr/2558 <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2558 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/e2ed87c/docs Examples preview: https://rerun.io/preview/e2ed87c/examples <!-- pr-link-docs:end --> ### Testing In order to test this I used the `run_all.py` script and found a bunch of issues with is, so I fixed them.      
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
use the
egui_tiles::Gridauto-layout feature incrates/re_viewer/src/ui/space_view_heuristics.rsThe text was updated successfully, but these errors were encountered: