Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error setting Ctrl-C handler: MultipleHandlers #2178

Closed
Tracked by #2113
albx79 opened this issue May 21, 2023 · 3 comments · Fixed by #2207
Closed
Tracked by #2113

Error setting Ctrl-C handler: MultipleHandlers #2178

albx79 opened this issue May 21, 2023 · 3 comments · Fixed by #2207
Labels
🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team

Comments

@albx79
Copy link

albx79 commented May 21, 2023

Describe the bug
Running the cargo-installed CLI tools panics immediately, with the error in the title.

To Reproduce

  1. cargo install rerun
  2. RUST_LOG=debug rerun

See error:

thread 'main' panicked at 'Error setting Ctrl-C handler: MultipleHandlers', rerun-0.5.1/src/run.rs:635

   6: core::panicking::panic_fmt
             at core/src/panicking.rs:64:14
   7: core::result::unwrap_failed
             at core/src/result.rs:1750:5
   8: rerun::run::setup_ctrl_c_handler
   9: rerun::run::run::{{closure}}
  10: tokio::runtime::park::CachedParkThread::block_on
  11: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
  12: tokio::runtime::runtime::Runtime::block_on
  13: rerun::main

Troubleshooting Rerun: https://www.rerun.io/docs/getting-started/troubleshooting
[2023-05-21T17:07:30Z DEBUG re_analytics::sink_native] {
      "api_key": "phc_sgKidIE4WYYFSJHd8LEYY1UZqASpnfQKeMqlJfSXwqg",
      "batch": [
        {
          "timestamp": "2023-05-21T17:07:30.093360341Z",
          "event": "crash-panic",
          "distinct_id": "d49da5f1-f9b5-4bbb-90b5-3e83ea1e1972",
          "properties": {
            "git_hash": "v0.5.1",
            "debug": false,
            "llvm_version": "15.0.7",
            "target": "x86_64-unknown-linux-gnu",
            "event_id": 1,
            "file_line": "rerun-0.5.1/src/run.rs:635",
            "session_id": "19ba9d47-294a-4abd-95cf-0ef410d94c2e",
            "build_date": "2023-05-21T12:49:02Z",
            "rust_version": "1.69.0 (84c898d65 2023-04-16)",
            "callstack": "   6: core::panicking::panic_fmt\n             at core/src/panicking.rs:64:14\n   7: core::result::unwrap_failed\n             at core/src/result.rs:1750:5\n   8: rerun::run::setup_ctrl_c_handler\n   9: rerun::run::run::{{closure}}\n  10: tokio::runtime::park::CachedParkThread::block_on\n  11: tokio::runtime::scheduler::multi_thread::MultiThread::block_on\n  12: tokio::runtime::runtime::Runtime::block_on\n  13: rerun::main",
            "rerun_version": "0.5.1",
            "rerun_workspace": false
          }
        }
      ]
    }

Expected behavior
Either show a window, or a user-friendly error message to explain what I did wrong.

Screenshots
N/A

Backtrace

   6: core::panicking::panic_fmt
             at core/src/panicking.rs:64:14
   7: core::result::unwrap_failed
             at core/src/result.rs:1750:5
   8: rerun::run::setup_ctrl_c_handler
   9: rerun::run::run::{{closure}}
  10: tokio::runtime::park::CachedParkThread::block_on
  11: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
  12: tokio::runtime::runtime::Runtime::block_on
  13: rerun::main

Desktop (please complete the following information):
Linux Fedora 38
Linux localhost.localdomain 6.2.14-300.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Mon May 1 00:55:28 UTC 2023 x86_64 GNU/Linux

Rerun version

rerun 0.5.1 [rustc 1.69.0 (84c898d65 2023-04-16), LLVM 15.0.7] x86_64-unknown-linux-gnu, built 2023-05-21T12:49:02Z

Additional context
Using the runner as a library from my rust program works fine. This problem happens only with the runner installed by cargo.

@albx79 albx79 added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels May 21, 2023
@emilk
Copy link
Member

emilk commented May 22, 2023

Thanks for the report! This works on main, so this will be fixed by the upcoming 0.6.0 release

@emilk emilk closed this as completed May 22, 2023
@emilk
Copy link
Member

emilk commented May 25, 2023

This could still happen for users using rerun as a dependency, but it should be properly fixed by #2198 now

@emilk emilk reopened this May 25, 2023
@emilk
Copy link
Member

emilk commented May 25, 2023

Actually, this can still happen for users that do cargo update -p ctrlc. We should pin ctrlc

This was referenced May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants