Simpler SIGINT handling #2198
Merged
Simpler SIGINT handling #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had a lot of trouble setting everything up on Windows. It boils down to a lot of stuff assuming bash exists and symlinks work.
But |
|
Awesome - can you please create a tracking issue for all Windows problems? |
jprochazk
reviewed
May 24, 2023
jprochazk
reviewed
May 24, 2023
jprochazk
approved these changes
May 24, 2023
Done: #2200 |
This was referenced May 25, 2023
emilk
added a commit
that referenced
this pull request
May 25, 2023
* Call exit(42) on SIGINT when running `python -m rerun` * Make shutdown_rx optional for re_web_viewer_server * Remove SIGINT from crash_handler * Remove shutdown from re_ws_comms::server * Remove our complex ctrl-c shutdown handling * cargo fmt * Fix doctest * fix typo Co-authored-by: Jan Procházka <1665677+jprochazk@users.noreply.github.com> * Use u64::MAX --------- Co-authored-by: Jan Procházka <1665677+jprochazk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
python -m rerunneeds to shutdown on SIGINT. Python catches SIGINT though, and waits for the GIL to shut down. But if the viewer is running, we never return to Python. So instead we install our own SIGINT handler in Rust and just callstd::process::exiton SIGINT.Testing
Check that Ctrl-C works in all these situations:
cargo reruncargo rerun foo.rrdcargo run -p rerun-cli --features web_viewer -- --web-viewercargo run -p api_demo -- --servejust py-build && python -m rerunjust py-build -F web_viewer && ./examples/python/api_demo/main.py --servejust py-build --features web_viewer && python -m rerun --web-viewerChecklist
PR Build Summary: https://build.rerun.io/pr/2198