Click to select single point, double-click to select entire point cloud #2214
Labels
enhancement
New feature or request
📺 re_viewer
affects re_viewer itself
ui
concerns graphical user interface
Comments
emilk
added
enhancement
emilk
added a commit
that referenced
this issue
Jun 26, 2023
Closes #2214 Hovering a point cloud now hovers individual points. Clicking once selects a point (a single instance). Double-clicking selects the entire point-cloud (the entire entity). ### What With this PR, we always set the full instance key in the GPU picking buffer. When reading we decide whether to look at both entity and instance (hover/click single instances) or to only look at the entity path (select whole point-cloud on double-click). Previously what was put in the GPU picking buffer depended on what was already selected. The new code is a lot simpler. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2504 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/c7f9332/docs Examples preview: https://rerun.io/preview/c7f9332/examples <!-- pr-link-docs:end -->
emilk
added a commit
that referenced
this issue
Jun 29, 2023
Closes #2214 Hovering a point cloud now hovers individual points. Clicking once selects a point (a single instance). Double-clicking selects the entire point-cloud (the entire entity). ### What With this PR, we always set the full instance key in the GPU picking buffer. When reading we decide whether to look at both entity and instance (hover/click single instances) or to only look at the entity path (select whole point-cloud on double-click). Previously what was put in the GPU picking buffer depended on what was already selected. The new code is a lot simpler. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2504 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/c7f9332/docs Examples preview: https://rerun.io/preview/c7f9332/examples <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently a single click selects the point cloud, and a second click selects the single point.
I suggest we instead use single-click to select a single point, and double-click to select the entire point cloud. This is similar to how clicking once in text will set the cursor and double-clicking will select the word. I think it is more intuitive.
It will also reduce flicker when moving the mouse over many points.
It also makes sense that hovering a point will show info about that single point, not the whole point cloud.
The text was updated successfully, but these errors were encountered: