Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun CLI image previewer seems broken on main #2507

Closed
Tracked by #2779
teh-cmc opened this issue Jun 25, 2023 · 1 comment · Fixed by #2807
Closed
Tracked by #2779

Rerun CLI image previewer seems broken on main #2507

teh-cmc opened this issue Jun 25, 2023 · 1 comment · Fixed by #2807
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Milestone
0.8

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 25, 2023

Loading any image just hangs permanently for me.

image
@teh-cmc teh-cmc added 🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release labels Jun 25, 2023
@emilk
Copy link
Member

emilk commented Jun 27, 2023

I can reproduce. It doesn't hang (the ui is responsive), it just never shows anything.

@Wumpf Wumpf mentioned this issue Jul 24, 2023
Closed
11 tasks
@Wumpf Wumpf self-assigned this Jul 25, 2023
@Wumpf Wumpf mentioned this issue Jul 25, 2023
Merged
3 tasks
teh-cmc added a commit that referenced this issue Jul 25, 2023
@Wumpf @teh-cmc
Fix loading file via CLI (#2807)
077e65f 
### What

Setting the `StoreSource` now before sending the file, propagating
information about the kind of startup/store.

Fixes #2507
* #2507

<img width="1210" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/d9f15b59-1981-41d8-aaf7-f64f7f552cc5">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2807) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2807)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-cli-file-loading/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-cli-file-loading/examples)

---------

Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
@abey79 abey79 added this to the 0.8 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Fix loading file via CLI rerun-io/rerun
4 participants
@emilk @Wumpf @teh-cmc @abey79