Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce transparency at the semantic layer #2526

Closed
teh-cmc opened this issue Jun 26, 2023 · 0 comments · Fixed by #2611
Closed

Introduce transparency at the semantic layer #2526

teh-cmc opened this issue Jun 26, 2023 · 0 comments · Fixed by #2611

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 26, 2023

We need a generic way to flatten Flatbuffers definitions before we even reach the type resolution pass, because the flatc compiler has a bunch of annoying hardcoded rules that makes sense for it but not for us, e.g.:

  • have to wrap scalars in a table when defining a union,
  • cannot put arrays (as opposed to vectors) in tables,
  • etc.

These will be way too annoying when implementing all the transforms types.

We already have a hack today in the form of the fbs.scalars package: this would be a nice generalization of that.
Let's introduce the almighty transparent attribute.

teh-cmc added a commit that referenced this issue Jul 6, 2023
Prerequisite for unions, since Flatbuffers has many union-specific
hardcoded limitations that are very annoying for us.

Fixes #2526

---

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2611) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2611)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Fsemantic_transparency/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fsemantic_transparency/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant