Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically derive attr.arrow.transparent for components #2606

Closed
teh-cmc opened this issue Jul 5, 2023 · 0 comments · Fixed by #2608
Closed

Automatically derive attr.arrow.transparent for components #2606

teh-cmc opened this issue Jul 5, 2023 · 0 comments · Fixed by #2608
Labels
🏹 arrow concerning arrow codegen/idl

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jul 5, 2023

Now that components can only have a single-field, it makes no sense to have to specify attr.arrow.transparent for each of them (it still makes sense between datatypes that build on top of one another though).
@teh-cmc teh-cmc added 🏹 arrow concerning arrow codegen/idl labels Jul 5, 2023
@teh-cmc teh-cmc mentioned this issue Jul 5, 2023
Merged
3 tasks
@teh-cmc teh-cmc changed the title Automatically dervied attr.arrow.transparent for components Automatically derive attr.arrow.transparent for components Jul 5, 2023
teh-cmc added a commit that referenced this issue Jul 5, 2023
@teh-cmc @abey79
Automatically assume arrow transparency for components (#2608)
f99bec5 
Fixes #2606 
On top of #2603 (requires single-field `Point2D` component)

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2608) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2608)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Fcomponent_always_arrow_transparent/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fcomponent_always_arrow_transparent/examples)

---------

Co-authored-by: Antoine Beyeler <antoine@rerun.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏹 arrow concerning arrow codegen/idl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically assume arrow transparency for components rerun-io/rerun
1 participant
@teh-cmc