Update the example manifest from the web #3190
Labels
Comments
abey79
added
enhancement
This was referenced Sep 3, 2023
abey79
added a commit
that referenced
this issue
Sep 6, 2023
### What Add Example page to the Welcome Screen. Fixes #3096 <img width="1366" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/bbe2e84e-9ade-4da8-b095-d7b0f396c26f"> ### TODO - [x] fix layout issues - [x] display tags - [x] have dedicated, short copy for the description: #3201 ### Not included in this PR - **WARNING**: here, we bake in a manifest with hard-coded links to RRDs that were generated within this PR. This will lead to issue down the line, when the RRD format changes. - #3212 - #3213 - download updated manifest - #3190 - load thumbnail from the web - emilk/egui#3291 - provide feedback while downloading a RRD - #3192 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3191) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3191) - [Docs preview](https://rerun.io/preview/3be107e4cc6aa6758a3f22c27a79233b33f2ea6b/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/3be107e4cc6aa6758a3f22c27a79233b33f2ea6b/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
jprochazk
added a commit
that referenced
this issue
Dec 1, 2023
### What * Closes #4278 * Closes #3190 - it's now possible to patch the manifest for a previously released version, starting with the next release. - [x] Stop including `examples_manifest.json` as part of the binary in favor of downloading it from `app.rerun.io` - [x] Move `re_viewer/build.rs` logic to a separate binary crate - [x] Native: Manifest URL override via a runtime env var - [x] Web: Manifest URL override via query param (`manifest_url`) - [x] CI: Build and upload `examples_manifest.json` together with every build of the web app for: - `/commit` - `/pr` - `/version/nightly` - `/version/{tag}` - `/prerelease` - `/latest` - [x] PR template: Link to app using both nightly and PR examples manifest ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Full build: [app.rerun.io](https://app.rerun.io/pr/4391/index.html) * Partial build: [app.rerun.io](https://app.rerun.io/pr/4391/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) - Useful for quick testing when changes do not affect examples in any way * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4391) - [Docs preview](https://rerun.io/preview/cf3b24badc3c29a75442aa2eb27ba7eeadcdb7ac/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/cf3b24badc3c29a75442aa2eb27ba7eeadcdb7ac/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The manifest that back the Welcome Screen's examples page is currently backed in the binary. Although is nice to have something by default, we should attempt to update that manifest based on the the latest version online. This would allow us to dynamically update the example list without a binary release.
The text was updated successfully, but these errors were encountered: