Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from mime_guess to mime_guess2 #3774

Closed
teh-cmc opened this issue Oct 10, 2023 · 3 comments · Fixed by #3795
Closed

Migrate from mime_guess to mime_guess2 #3774

teh-cmc opened this issue Oct 10, 2023 · 3 comments · Fixed by #3795
Labels
dependencies concerning crates, pip packages etc

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Oct 10, 2023 •
edited
Loading

mime_guess is unmaintained and already missing some important stuff such as JPEG XL.

Also I'd like to contribute to mime_guess2 at some point so that .obj defaults to wavefront rather than tgif (see #3772).

But for that we need to migrate egui_commonmark egui-extras off of mime_guess first.
@teh-cmc teh-cmc added the dependencies concerning crates, pip packages etc label Oct 10, 2023
@teh-cmc teh-cmc mentioned this issue Oct 11, 2023
Merged
4 tasks
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 11, 2023

I misread the output of cargo tree earlier: egui_commonmark isn't the source of the conflict, it's egui_extras.

I'll make a PR.

@teh-cmc teh-cmc mentioned this issue Oct 11, 2023
Merged
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 11, 2023

We need emilk/egui#3456 to be merged and released now.

@teh-cmc
Copy link
Member Author

teh-cmc commented Nov 28, 2023

teh-cmc added a commit that referenced this issue Dec 15, 2023
@teh-cmc
Migrate to mime_guess2 (#3795)
f2382b1 
Blocked on emilk/egui#3456 to be merged and
released.

- Fixes #3774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to mime_guess2 rerun-io/rerun
1 participant
@teh-cmc