Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeless counter underflow warning when opening plots example with old blueprint #4355

Closed
Wumpf opened this issue Nov 28, 2023 · 4 comments
Closed

Timeless counter underflow warning when opening plots example with old blueprint #4355

Wumpf opened this issue Nov 28, 2023 · 4 comments
Labels
🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself

Comments

@Wumpf
Copy link
Member

Wumpf commented Nov 28, 2023

Got this warning:

[2023-11-27T18:13:31Z WARN  re_data_store::time_histogram_per_timeline] Timeless counter underflowed, store events are bugged!

when opening the plots demo with an outdated blueprint.

Note that we changed this to be a debug warning on the 0.11.0 release branch
@Wumpf Wumpf added 🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself labels Nov 28, 2023
Wumpf added a commit that referenced this issue Nov 28, 2023
@Wumpf
demoting timeless counter underflow warning to debug. See #4355
badde3b
@emilk
Copy link
Member

emilk commented Jan 10, 2024

Let's verify this is a debug-only warning.

Can we repro it?
Can we improve the error message to help figure out what goes wrong?

@teh-cmc
Copy link
Member

teh-cmc commented Jan 10, 2024

Let's verify this is a debug-only warning.

Ha no, I remember now (by which I mean Andreas pointed that out just above 🤦‍♂️): we only changed it on the release branch for 0.11.

Yeah this should really always be a debug log, especially now that we enable debug logs by default in debug builds: there's nothing that an end-user can do with that information beside being scared.

@teh-cmc teh-cmc changed the title Timless counter underflow warning when opening plots example with old blueprint Timeless counter underflow warning when opening plots example with old blueprint Jan 10, 2024
@teh-cmc teh-cmc self-assigned this Jan 10, 2024
@teh-cmc teh-cmc mentioned this issue Jan 10, 2024
Merged
4 tasks
@teh-cmc teh-cmc removed their assignment Jan 10, 2024
teh-cmc added a commit that referenced this issue Jan 10, 2024
@teh-cmc
Replace warn logging with debug logging for dangerous looking {un…
59303a3 
…der|over}flows (#4771)

A quick pass over all dangerous looking
`{checked|saturating}_{sub|add}`s I could find.

They will now all log in DEBUG (reminder: we now show DEBUG logs by
default in debug builds) and print as many information as possible.
They will also all behave as a saturating operation in case of failure.

I've also removed the `_once`: whether this repeats or not might
actually help us track the root cause.

I couldn't reproduce the issue in #4355, so don't know about that.

- Part of #4355
@Wumpf
Copy link
Member Author

Wumpf commented Jan 16, 2024

so the only action point is to make this a debug log? Okay!

@Wumpf Wumpf added the 🏎️ Quick Issue Can be fixed in a few hours or less label Jan 16, 2024
@emilk emilk removed the 🏎️ Quick Issue Can be fixed in a few hours or less label Jan 16, 2024
@emilk
Copy link
Member

emilk commented Jan 16, 2024

We haven't seen this in a while 🤷

@emilk emilk closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emilk @Wumpf @teh-cmc