Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing entity from blueprint panel sometimes collapses parent #4453

Closed
Tracked by #4377
roym899 opened this issue Dec 7, 2023 · 0 comments · Fixed by #4548
Closed
Tracked by #4377

Removing entity from blueprint panel sometimes collapses parent #4453

roym899 opened this issue Dec 7, 2023 · 0 comments · Fixed by #4548
Assignees
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Milestone

Comments

@roym899
Copy link
Collaborator

roym899 commented Dec 7, 2023

Describe the bug
When removing entities in the blueprint panel sometimes the parent collapses when removing a child. This seems to happen only sometime, maybe depending on the number of children left. This is quite annoying when trying to remove multiple entities, and there's no reason to collapse here.

2023-12-07.11-46-47.mp4

To Reproduce

import numpy as np
import rerun as rr

rr.init("collapsing", spawn=True)
rr.log("parent/p1", rr.Points3D(np.random.rand(10,3)))
rr.log("parent/p2", rr.Points3D(np.random.rand(10,3)))
rr.log("parent/p3", rr.Points3D(np.random.rand(10,3)))
rr.log("parent/p4", rr.Points3D(np.random.rand(10,3)))
rr.log("parent/p5", rr.Points3D(np.random.rand(10,3)))
rr.log("parent/p6", rr.Points3D(np.random.rand(10,3)))

Expected behavior
Remove without collapsing.

Desktop (please complete the following information):

  • OS: Ubuntu 20.04

Rerun version

rerun_py 0.12.0-alpha.1+dev [rustc 1.74.0 (79e9716c9 2023-11-13), LLVM 17.0.4] x86_64-unknown-linux-gnu
@roym899 roym899 added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team 📺 re_viewer affects re_viewer itself labels Dec 7, 2023
@Wumpf Wumpf removed the 👀 needs triage This issue needs to be triaged by the Rerun team label Dec 8, 2023
@Wumpf Wumpf added this to the 0.12 milestone Dec 8, 2023
@Wumpf Wumpf added the 🟦 blueprint The data that defines our UI label Dec 12, 2023
@jleibs jleibs self-assigned this Dec 14, 2023
jleibs added a commit that referenced this issue Dec 15, 2023
### What
 - Resolves: #4453

Needed to make the id deterministic since the value of DataResultHandle
was basically just a function of how many children the data-result had.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4548/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4548/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4548/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4548)
- [Docs
preview](https://rerun.io/preview/456b9b77eb6e2ac6a7be4a0dc28b811f308fb450/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/456b9b77eb6e2ac6a7be4a0dc28b811f308fb450/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants