Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding entities from cloned space view in blueprint panel hides entity in original view instead #4456

Closed
roym899 opened this issue Dec 7, 2023 · 0 comments
Closed

Hiding entities from cloned space view in blueprint panel hides entity in original view instead #4456

roym899 opened this issue Dec 7, 2023 · 0 comments
Assignees
@jleibs
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Milestone
0.12

Comments

@roym899
Copy link
Collaborator

roym899 commented Dec 7, 2023

Describe the bug
See title + video below

2023-12-07.13-48-39.mp4

Hiding / showing works fine from right-hand side panel.

To Reproduce

import rerun as rr
import numpy as np

rr.init("minimal", spawn=True)

rr.log("image/color", rr.Image(np.random.rand(100, 100, 3)))
rr.log("image/depth", rr.DepthImage(np.random.rand(100, 100)))
  1. Clone the default view
  2. Hide entity in cloned view in blueprint panel (as in video) -> entity in original view gets hidden

Expected behavior
Clicked on entity should be hidden instead.

Desktop (please complete the following information):

  • OS: Ubuntu 20.04

Rerun version

rerun_py 0.11.0 [rustc 1.72.1 (d5c2e9c34 2023-09-13), LLVM 16.0.5] x86_64-unknown-linux-gnu release-0.11.0 61e3de1, built 2023-11-28T12:46:51Z
@roym899 roym899 added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team 📺 re_viewer affects re_viewer itself labels Dec 7, 2023
@roym899 roym899 changed the title Hiding entities from cloned space view in blueprint panel will hide entity in original view instead Hiding entities from cloned space view in blueprint panel hides entity in original view instead Dec 7, 2023
@Wumpf Wumpf added this to the 0.12 milestone Dec 8, 2023
@Wumpf Wumpf added 🟦 blueprint The data that defines our UI and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Dec 8, 2023
@jleibs jleibs self-assigned this Dec 15, 2023
@jleibs jleibs mentioned this issue Dec 15, 2023
Merged
4 tasks
Wumpf pushed a commit that referenced this issue Dec 15, 2023
@jleibs
When duplicating a SpaceViewBlueprint, also duplicate its Query (#4549)
2b2b0db 
### What
- Resolves: #4456

The crux of the problem is cloning the SpaceView created a new SpaceView
with the same DataQuery reference (which is where the property overrides
are stored).

Since cloning the internal IDs of a SpaceView or DataQuery can have
unintended consequences, I removed Clone from these types and replaced
it with a `duplicate` method with clearer semantics.

Also had to clean up the heuristic path to get rid of the one otherwise
unnecessary clone.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4549/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4549/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4549/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4549)
- [Docs
preview](https://rerun.io/preview/f128e543a4e06edee55f1a089b1b6a9837ca43b0/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/f128e543a4e06edee55f1a089b1b6a9837ca43b0/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@jleibs jleibs closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
3 participants
@Wumpf @jleibs @roym899