Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning a space view doesn't clone all of its configuration state #4977

Closed
teh-cmc opened this issue Jan 31, 2024 · 3 comments · Fixed by #5076
Closed

Cloning a space view doesn't clone all of its configuration state #4977

teh-cmc opened this issue Jan 31, 2024 · 3 comments · Fixed by #5076
Assignees
@jleibs
Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 📺 re_viewer affects re_viewer itself
Milestone
0.13

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 31, 2024

  • Have e.g. a 3D point cloud view
  • Set visible time range to -inf:+inf
  • Clone the view -> the cloned view is back to default settings (LatestAt(cur_frame))
@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 📺 re_viewer affects re_viewer itself 😤 annoying Something in the UI / SDK is annoying to use labels Jan 31, 2024
@abey79 abey79 mentioned this issue Jan 31, 2024
Merged
4 tasks
@jleibs jleibs changed the title Cloning a space view doesn't clone its visible time range settings Cloning a space view doesn't clone all of its configuration state, such as visible time range settings Jan 31, 2024
@jleibs
Copy link
Member

jleibs commented Jan 31, 2024

Note that this same problem applies to child entity-properties, component overrides, etc.

@abey79 abey79 changed the title Cloning a space view doesn't clone all of its configuration state, such as visible time range settings Cloning a space view doesn't clone all of its configuration state Jan 31, 2024
@abey79
Copy link
Member

abey79 commented Jan 31, 2024

#4978 partially addresses this by properly cloning the entity properties.

abey79 added a commit that referenced this issue Jan 31, 2024
@abey79
Fix space view cloning to also copy entity properties (visible time r…
82e229c 
…ange, etc.) (#4978)

### What

* Part of #4977 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4978/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4978/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4978/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4978)
- [Docs
preview](https://rerun.io/preview/a5e046a0c391cb0928bc2aff540bebfc93e60ce9/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/a5e046a0c391cb0928bc2aff540bebfc93e60ce9/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@jleibs jleibs mentioned this issue Feb 2, 2024
Merged
5 tasks
jleibs added a commit that referenced this issue Feb 2, 2024
@Wumpf @jleibs
Move legend position & visibility to its own archetype (#5006)
55576c7 
### What

* Part of #4818

Introduces new system of sub archetypes: Each space view has its own
small tree of properties.
Used this to move over the already existing plot options (no functional
change in this PR!), but all remaining plot properties can then be moved
to this new more versatile system.

Draft:
* ~~[ ] use component editors for visibility and legend position~~
  * Punting for future UI unification
* ~~[ ] make cloning of space views work (this now needs to copy the
entire blueprint subtree)~~
  * Will address in: #4977
* [x] test it out a bit more, self review

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5006/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5006/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5006/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/5006)
- [Docs
preview](https://rerun.io/preview/1bea7468aa745f6322c7e1873b15787ffc11a920/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/1bea7468aa745f6322c7e1873b15787ffc11a920/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
@jleibs jleibs added this to the 0.13 milestone Feb 3, 2024
@jleibs
Copy link
Member

jleibs commented Feb 3, 2024

Adding to 0.13 because the new legend / axis config depend on it.

@jleibs jleibs self-assigned this Feb 6, 2024
@jleibs jleibs mentioned this issue Feb 7, 2024
Merged
5 tasks
jleibs added a commit that referenced this issue Feb 7, 2024
@jleibs
When duplicating a space-view copy the nested blueprint tree (#5076)
79d8021 
### What
 - Resolves: #4977

When we duplicate the space-view we now copy the entire subtree and
write it into the new view. We do the same, recursively for the
DataQueries as well (which is where the component overrides live).

There's definitely some cleanup that could be done here but this seems
to work for now to solve the problem of duplicating all the overrides,
etc.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5076/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5076/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5076/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5076)
- [Docs
preview](https://rerun.io/preview/60420debd92234b2537b29d870aefe44ad6aab54/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/60420debd92234b2537b29d870aefe44ad6aab54/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

When duplicating a space-view copy the nested blueprint tree rerun-io/rerun
3 participants
@teh-cmc @jleibs @abey79