Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking "-" to remove entity doesn't work if children were included explicitly #5690

Closed
jleibs opened this issue Mar 26, 2024 · 0 comments · Fixed by #5720
Closed

Clicking "-" to remove entity doesn't work if children were included explicitly #5690

jleibs opened this issue Mar 26, 2024 · 0 comments · Fixed by #5720
Assignees
@jleibs
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working ui concerns graphical user interface
Milestone
0.15

Comments

@jleibs
Copy link
Member

jleibs commented Mar 26, 2024

Exa

consider expression:

+ /stocks/META/2024-03-25
+ /stocks/MSFT/2024-03-25

Clicking the "-" next to META in the tree
image

Just results in:

- /stocks/META/**
+ /stocks/META/2024-03-25
+ /stocks/MSFT/2024-03-25

But this new rule has no effect since it's overridden by the inclusions.

I believe in this case we should walk the query tree and properly remove recursively.
@jleibs jleibs added 🪳 bug Something isn't working ui concerns graphical user interface 🟦 blueprint The data that defines our UI labels Mar 26, 2024
@jleibs jleibs added this to the 0.15 milestone Mar 26, 2024
@jleibs jleibs mentioned this issue Mar 28, 2024
Merged
5 tasks
jleibs added a commit that referenced this issue Mar 29, 2024
@jleibs
Also remove nested inclusions when removing a subtree (#5720)
bcd2092 
### What
- Resolves: #5690

Introduce new helper method that not only adds an exclusion but also
removes all the current matches within the subtree.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5720/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5720/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5720/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5720)
- [Docs
preview](https://rerun.io/preview/fe3ca4a5457776f4ade8171ce94b332b18fdf40e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/fe3ca4a5457776f4ade8171ce94b332b18fdf40e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Also remove nested inclusions when removing a subtree rerun-io/rerun
1 participant
@jleibs