Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use codegen for ViewDir enum #6320

Open
Wumpf opened this issue May 14, 2024 · 0 comments
Open

Use codegen for ViewDir enum #6320

Wumpf opened this issue May 14, 2024 · 0 comments
Labels
🪵 Log & send APIs Affects the user-facing API for all languages other Generated by the "Other" issue template 🍏 primitives Relating to Rerun primitives 🚜 refactor Change the code, not the functionality

Comments

@Wumpf
Copy link
Member

Wumpf commented May 14, 2024

We have codegen for enums but we haven't used it so far in for ViewDir which predates the addition of enums.

This change would require some api breaking changes since ViewDir is scoped to ViewCoordinates in some SDK languages. As there's other major refactoring expected in this area, it should likely be done in conjunction with that.

See
@Wumpf Wumpf added other Generated by the "Other" issue template 🚜 refactor Change the code, not the functionality 🍏 primitives Relating to Rerun primitives 🪵 Log & send APIs Affects the user-facing API for all languages labels May 14, 2024
@Wumpf Wumpf mentioned this issue May 14, 2024
Merged
6 tasks
Wumpf added a commit that referenced this issue May 14, 2024
@Wumpf
Cleanup of todos referring to closed tickets (#6323)
3805781 
### What

Make `pixi run python ./scripts/zombie_todos.py` happy.

Removed some dead code in the process. Two tickets were opened to
account for stuff that's actually not quite done:
* #6321
* #6320

Commit by commit: I put everything noteworth into its own commit and put
the general less deep cleanup last (still has various judgement calls)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6323?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6323?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] Succeed a main pr check since the pyproject.toml change makes me
nervous

- [PR Build Summary](https://build.rerun.io/pr/6323)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪵 Log & send APIs Affects the user-facing API for all languages other Generated by the "Other" issue template 🍏 primitives Relating to Rerun primitives 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wumpf