Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting an instance containing a batch of keypoint_id + class_id spams a warning: "not a mono-batch" #6358

Closed
jleibs opened this issue May 16, 2024 · 3 comments
Labels
🪳 bug Something isn't working ui concerns graphical user interface

Comments

@jleibs
Copy link
Member

jleibs commented May 16, 2024

Easy repro using the face_tracking example.

python -m face_tracking

then select any keypoint.

image

Text of the warning:

Processing frames: 691it [00:23, 27.51it/s][2024-05-16T13:16:52Z WARN  re_query::latest_at::helpers] Couldn't deserialize /reconstruction/faces/0:rerun.components.ClassId @ TimeInt(690)#17CFFA806598864D24D999916925D29D: not a mono-batch (length: 478)

Root cause

The cause of the problem comes from:

let class_id = ctx
.recording()
.latest_at_component::<re_types::components::ClassId>(entity_path, query)?;

We are using latest_at_component which depends on a mono-component, but the keypoint is an instance of a batch.

To fix this properly, we need to track the instance all the way through EntityDataUi and use it to look up the correct class-id.

Affects

0.15, 0.16

@jleibs jleibs added ui concerns graphical user interface 🦟 regression A thing that used to work in an earlier release labels May 16, 2024
@jleibs
Copy link
Member Author

jleibs commented May 16, 2024

In: #6359 we made this incrementally better by getting rid of the log spam

@teh-cmc teh-cmc added 🪳 bug Something isn't working and removed 🦟 regression A thing that used to work in an earlier release labels May 16, 2024
Wumpf pushed a commit that referenced this issue May 16, 2024
…batch class-id (#6359)

### What
- Partially mitigates: #6358

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6359?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6359?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6359)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Wumpf pushed a commit that referenced this issue May 16, 2024
…batch class-id (#6359)

### What
- Partially mitigates: #6358

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6359?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6359?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6359)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@emilk
Copy link
Member

emilk commented May 16, 2024

Looks like this issue is finally producing real problems:

@emilk
Copy link
Member

emilk commented May 16, 2024

In fact, I'm closing this as a duplicate of #3168

@emilk emilk closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Wumpf pushed a commit that referenced this issue May 17, 2024
…batch class-id (#6359)

### What
- Partially mitigates: #6358

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6359?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6359?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6359)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants