Clear logic needs to be handled by the store and/or query engine
#6454
Assignees
Labels
Comments
teh-cmc
changed the title
Clear logic needs to be handle by the store and/or query engineClear logic needs to be handled by the store and/or query engine
teh-cmc
added a commit
that referenced
this issue
Jul 4, 2024
Resolves pending clears at query time, rather than through write cascades. Only works for latest-at queries for now. We'll take care of range queries once the deserialization cache has been removed, it's just not worth dealing with all the extra complexity at the moment. The only visible change for users is that the "scalar plot hole" feature doesn't work anymore. - Fixes #6454 - Fixes #4220 - Fixes #3287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clears (as inlog(rr.Clear())) are currently implemented using the very ad-hoc write cascades inEntityDb.This was never great, and it's likely to become much worse as we move the store to disk, expose APIs to read data back, etc.
I haven't put any thought into it, but it should probably be possible to resolve those clears at query time, directly within
re_data_storeorre_query, at the cost of a few extra latest-at queries (one per parent in the hierarchy), which really shouldnt be an issue.Even GC should be manageable by keeping all chunks that contain a
Clearcomponent as long as possibly necessary.The text was updated successfully, but these errors were encountered: