-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU memory not freed when closing recording, but keeping viewer open #6755
Comments
Likely at least partially related to we're also not good at freeing up anything in that staging belt. However, one would expect to at least the meshes to disappear from the MeshCache, that's apparently not happening! |
Why did #7513 not help with this at all? |
I though #7531 would fix this issue, however turns out that it is already fixed. The ratched behavior of the memory.free.mp4 |
### What * ~Fixes #6755~ * upon counter check with `main` this was already fixed Removes the re_renderer `MeshManager` in its entirety. The vision here was at some point to provide a manager to deal with both short-lived and long-lived resource that are identified by a content hash/identifier similar to the texture manager. However, as things shifted around this didn't end up being useful: _all_ meshes ever supplied were marked as long-lived and held alive by a ref counter. We ended up just holding on to the ref count in a central place rather than tracking resource creation & destruction properly. Overall architecture of gpu resource handling leaned more and more towards shared ownership via caches, making the MeshManager an unnecessary layer. The drawback of this is that we have a lot more Arcs which might bite us at some point (overhead + hard to track who owns), but I don't see that happening any time soon (I'm sure this is gonna get quoted a year from now when it stops working 😁 ). --------- Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Describe the bug
It seems like GPU memory is not freed when closing the recording for meshes (only noticed / tested for meshes with large number of vertices, not sure how generally this applies).
As a workaround I have to close the viewer occasionally.
To Reproduce
Run the following code a few times while monitoring GPU memory usage. Memory keeps growing and closing the recordings does not free it.
Expected behavior
Memory should be freed when closing a recording in the viewer.
Screenshots
vram.mp4
Note that "Counted GPU" only goes up, never down.
Backtrace
Desktop (please complete the following information):
Rerun version
Also tested with
0.16.1
.The text was updated successfully, but these errors were encountered: