Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineStrips2D radii not working as expected for real world data #7191

Closed
Famok opened this issue Aug 15, 2024 · 4 comments · Fixed by #8065
Closed

LineStrips2D radii not working as expected for real world data #7191

Famok opened this issue Aug 15, 2024 · 4 comments · Fixed by #8065
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself

Comments

@Famok
Copy link

Famok commented Aug 15, 2024

Describe the bug
The radii of Linestrips2D does not what I expect it to do, which is to increase the line width.
Instead it only increases the width of each segment, which will lead to a weird behaviour if you have real world data (e.g. with noise).

To Reproduce
Code to show the issue:

import rerun as rr
import numpy as np

x = np.linspace(0,2*np.pi,1000)
y = np.random.rand(len(x))*0.1

xy = np.array([x,y]).T

rr.init('testing', recording_id= ' test', spawn = True)
for r in [0.001, 1]:
    rr.log(
        f"random line {r=}",
        rr.LineStrips2D(
            [xy],
            radii=r
        ),
    )

Expected behavior
I was expecting the line as a whole to get wider (similar how this works in powerpoint for example).

Desktop (please complete the following information):
Windows 11 23H2

Rerun version
rerun_py 0.18.0-alpha.1+dev [rustc 1.76.0 (07dca489a 2024-02-04), LLVM 17.0.6] x86_64-pc-windows-msvc main 9e50d2c, built 2024-08-14T13:15:39Z

@Famok Famok added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Aug 15, 2024
@nikolausWest
Copy link
Member

Thanks for the issue @Famok!

Could you add some screenshots comparing what you're seeing in Rerun vs the behavior you're expecting (powerpoint)? We're having a little trouble interpreting exactly what you mean

@Wumpf
Copy link
Member

Wumpf commented Aug 15, 2024

took me a bit indeed but I think I see what you mean now, the line radius behaves strangely when it goes about individual line lengths:

weird.line.radii.mp4

Seems to be closely related to:

@abey79
Copy link
Member

abey79 commented Aug 15, 2024

Another depiction. Both are the same line. The yellow one has very thick segments. The "effect" is due to the lack of (miter/round) join handling.

image

@Famok
Copy link
Author

Famok commented Aug 15, 2024

@abey79 this is what I mean. For some reason I'm unable to upload images myself so I could show how my expected behavior looks like.

@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Oct 11, 2024
@Wumpf Wumpf closed this as completed in 03cb015 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants