Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add round joints to line strips #829

Closed
Wumpf opened this issue Jan 19, 2023 · 0 comments · Fixed by #8065
Closed

Add round joints to line strips #829

Wumpf opened this issue Jan 19, 2023 · 0 comments · Fixed by #8065
Assignees
@Wumpf
Labels
🔺 re_renderer affects re_renderer itself
Milestone
0.20 - Maps, H.264

Comments

@Wumpf
Copy link
Member

Wumpf commented Jan 19, 2023 •
edited by abey79
Loading

re_renderer doesn't create line miters so far!
@Wumpf Wumpf added the 🔺 re_renderer affects re_renderer itself label Jan 19, 2023
@Wumpf Wumpf mentioned this issue Jul 22, 2024
Closed
@Wumpf Wumpf mentioned this issue Aug 15, 2024
Closed
@abey79 abey79 changed the title Linestrips should to be connected Add round join to line strips Nov 1, 2024
@abey79 abey79 added this to the 0.20 - Maps, H.264 milestone Nov 1, 2024
This was referenced Nov 1, 2024
Closed
Merged
@Wumpf Wumpf self-assigned this Nov 4, 2024
abey79 added a commit that referenced this issue Nov 7, 2024
@abey79 @emilk @teh-cmc
Introduce the GeoLineStrings archetype and support it in the map vi…
aab0b4e 
…ew (#7968)

### What

☝🏻 title

- New `GeoLineStrings` archetype, using a new `GeoLineString` component
- Support it in the map view
- Fix heuristics for the map view: now a `$origin = /` single view will
be spawned whenever a single `GeoXXX` entity exists anywhere.
- Snippets and screenshot for `GeoPoints`
- Snippet for `GeoLineStrings` (but not screenshot, blocked on #829)
- Added some types to `rerun.hpp`
- Fixed/copy/pasted `LineStrip2D` edit ui for `GeoLineString`
- Add python unit tests for `GeoPoints`
- Add python unit tests for `GeoLineStrings`


Switzerland boundaries according to a couple of AIs and an official
source:

<img width="695" alt="image"
src="https://github.com/user-attachments/assets/4035f4dc-b2ee-42b1-9436-5f92a71a4de8">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7968?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7968?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7968)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
@Wumpf Wumpf changed the title Add round join to line strips Add round joints to line strips Nov 11, 2024
@Wumpf Wumpf mentioned this issue Nov 11, 2024
Merged
8 tasks
@Wumpf Wumpf closed this as completed in 03cb015 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
0.20 - Maps, H.264
Development

Successfully merging a pull request may close this issue.

Line strips are no longer a disconnected series of quads rerun-io/rerun
2 participants
@Wumpf @abey79